findNavController and isolated fragment

Question

I launch a BottomSheetDialogFragment from the main fragment with the show function (navigation component can't start DialogFragments).

Now in the BottomSheetDialogFragment I have a button to move to a detail activity.

I have the BottomSheetDialogFragment defined in the graph (isolated) and it points to the detail activity.

But when I try to navigate, it can't find the navController. Is it possible to pass the navController to this isolated fragment?

MainFragment to Detail is working DialogFragment to Detail is not working.

I tried: - findNavController: navigation is not set - activity.findNavController(...)

**MainFragment to Detail is working DialogFragment to Detail is not working.** It won't work because you opened it using `show` function. You need to start with navigation-component to continue with it. If you used `show` function` you better continue with it, Unless you choose the workaround I suggest in my answer below. — Ibrahim Ali, Apr 10 '19 at 21:40
see how to set animation using nav-comp https://developer.android.com/guide/navigation/navigation-animate-transitions — Ibrahim Ali, Apr 10 '19 at 21:50
@IbrahimAli I will try it in some days (I have to travel tomorrow) I will post the result — JavierSegoviaCordoba, Apr 10 '19 at 22:27

Ibrahim Ali · Answer 1 · 2019-04-10T21:19:37.070

1

But when I try to navigate, it can't find the navController. That's how navigation-component work.

Is it possible to pass the navController to this isolated fragment? I hope you will not going with that, replacing navController is not the perfect solution for your case.

What to do?

You can have new nav.xml with new parent activity and the (isolated) fragment as child, and navigate from the BottomSheetDialogFragment to (isolated) fragment-activity.

Otherwise, I don't see any problems that prevent you from adding related fragments in one nav.xml.

Also you may need to obey for navigation-component contract, don't use show() function while using navigation-component, you may miss some advantages here!

You really don't need show function see:-

Android Activity as a dialog

Explanation:-

You can have a parent activity and set it's theme as Dialog, so all fragments (inside the nav.xml) will be dialogs..

I used this trick in one of my apps before.

edited Apr 10 '19 at 21:19

answered Apr 10 '19 at 21:05

Ibrahim Ali

1,237
9
20

I have already a nav.xml for the detail activity. So I have to change the bottomsheetdialog from the main graph to the detail graph? – JavierSegoviaCordoba Apr 10 '19 at 21:07
@JavierSegoviaCordoba Indeed that won't fix your problem. – Ibrahim Ali Apr 10 '19 at 21:11
I have to use show(), it is not possible to use DialogFragment without it – JavierSegoviaCordoba Apr 10 '19 at 21:13
@JavierSegoviaCordoba **it is not possible to use DialogFragment without it** not true. you can use it without show function. – Ibrahim Ali Apr 10 '19 at 21:14
What about this in your fragment: (getActivity() as MyActivity).findNavController – Pedro Massango Apr 10 '19 at 21:17
@JavierSegoviaCordoba Well, I used it in my app, but I opened the activity as dialog, so all child fragment will be dialogs... – Ibrahim Ali Apr 10 '19 at 21:18
@PedroMassango it says me the navigation "name" is unknown to this NavController – JavierSegoviaCordoba Apr 10 '19 at 21:23
@IbrahimAli but I didn't want to have a lot of dialogs – JavierSegoviaCordoba Apr 10 '19 at 21:26
@JavierSegoviaCordoba You don't need to have a lot of dialogs, you only need that for the fragment you opened as dialog, i.e: assume you have `dialogs_nav.xml` and in it's activity you can check which fragment will opened by passing `navArgs` and open `NavDialogActivity` from any where. I tried this way before, no problem with it. – Ibrahim Ali Apr 10 '19 at 21:28
@IbrahimAli I added the nav graph – JavierSegoviaCordoba Apr 10 '19 at 21:31

findNavController and isolated fragment

1 Answers1