Is this the correct way to implement a cookie?

Question

I am running the following code which loads a div and hies it according to cookie but does not show it back again once a cookie is set.

I do not understand why this is not running.

<!DOCTYPE html>
<html>

<head></head>

    <body>
    <div style="width:250px;height:250px;background-color:#000;" id="PostShare">
    </div>
    </body>

    <script language="javascript" type="text/javascript" async>
    function createPages(name,value,days) {
       var date = new Date();
       date.setTime(date.getTime()+(days*24*60*60*1000));
       var expires = date.toGMTString();
       document.cookie = name+"="+value+"; expires="+expires+"; path=/";
    }

    function readPages(name) {
        var flag = 0;
        var dcmntPages = document.cookie.split(';');
        for(var i=0;i < dcmntPages.length;i++) {
            var ck = dcmntPages[i];
            while (ck.charAt(0)==' ') {
                ck = ck.substring(1,ck.length);
            }
            if(ck) {
                cparts = ck.split('=');
                if (cparts[0] == name) flag=1;
            }              
        }     
        if(flag) { 
            return true; 
        } else {
            return false; 
        }  
    }

    function checkPages(name) {
        if (readPages(name)) {
    document.getElementById('PostShare').style.display = "none";
    document.getElementById('PostShare').style.visibility = "hidden";
        }
        else {
    document.getElementById('PostShare').style.display = "block";
    document.getElementById('PostShare').style.visibility = "visible";
        createPages(name,"cookie 4 the day",1); 
        }
    }

    checkPages("MyPages");
    </script>
    </body>

</html>

I am trying the same on incognito and so but it does not work. Please help me understand how to make this code work or what should be the code for hiding a div for user on first load and showing it on rest of loads for the day.

Thanks

Please let me know if you have a solution. – Tarun Jain Apr 11 '19 at 09:36 — Tarun Jain, Apr 11 '19 at 09:36

score 0 · Answer 1 · answered Apr 11 '19 at 09:55

0

Your implementation looks good. If your viewing the page in your browser from file, cookies won't set. You need to host it on a server. You can run simple server to host your html file : - python - apache - npm

answered Apr 11 '19 at 09:55

kewwwa

137
4

I'll try putting it on a server and respond – Tarun Jain Apr 11 '19 at 10:10
Great. Working with files prevent some feature to work for security reasons. Remember to mark your question as resolved. – kewwwa Apr 11 '19 at 12:36

Is this the correct way to implement a cookie?

1 Answers1