Changes in Swift 5 to inheritance?

Question

We have a strange situation where behavior has changed from Swift 4 -> 5 and I can't figure out what is going wrong. We have our own open base table view controller class in a framework that conforms to UITableViewDatasource and UITableViewDelegate. In Swift 4 the subclasses could simply implement any of those delegate methods and they would work as expected. With Swift 5 and the latest Xcode this has all changed and any signature from those protocols that isn't explicitly written out in the base class are completely ignored, causing all kinds of strange bugs.

Our base class implementation looks something like this:

open class OsuTableViewController: OsuViewController, UITableViewDelegate, UITableViewDataSource {
    public let tableView = UITableView(frame: .zero, style: .grouped)

    public var tableSections = [OsuTableSection]()


    override open func viewDidLoad() {
        super.viewDidLoad()
        tableView.datasource = self
        tableView.delegate = self
    }


    open func numberOfSections(in tableView: UITableView) -> Int {
        return tableSections.count
    }

    open func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        switch tableSections[section].tableSectionType {
        default:
            return tableSections[section].rows.count
        }
    }

    open func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(OsuTableViewCell.self)
        return cell
    }
}

In Swift 4 any subclass then would be able to implement didSelectRowAtIndexPath or viewForHeaderInSection even without those declarations being explicitly stated in the base class.

class AboutYouCustomizeTableViewController: OsuTableViewController {
    // With Xcode 10.2 and Swift 5 this is never called.
    func tableView(_ tableView: UITableView, canEditRowAt indexPath: IndexPath) -> Bool {
        return true
    }
}

With Swift 5 we find that the signatures in the subclasses are simply ignored unless we start writing out every single one in the base class. This is painful and sometimes leads to undesired behavior. Is this an intentional change or a bug? How do we get the old behavior back?

Changes in Swift 5 to inheritance?

0 Answers0