Is it considered "bad practice" to use "@" to avoid errors?

Asked Apr 12 '19 at 19:56

Active Apr 12 '19 at 19:59

Viewed 41 times

Is using @ to repress errors considered bad practice? Take this code for an example:

...
$an_array = false;

if (something) $an_array = array("key" => "value); 

if (array_key_exists("key", $an_array)) ...

In my structure it can be, that an_array is still false when I want to use array_key_exists() on it. Is it considered bad practice to do: @array_key_exists()? Shall I use if (is_array($an_array) AND array_key_exists(...)) instead?

edited Apr 12 '19 at 19:59

asked Apr 12 '19 at 19:56

Stef

9

_Is it considered “bad practice” to use “@” do avoid errors?_ Yes it is. – AbraCadaver Apr 12 '19 at 19:58
thanks, then i wont use it – Stef Apr 12 '19 at 19:59
1

It definitely is. I'm pretty sure error suppression in any language is bad practice. – GrumpyCrouton Apr 12 '19 at 19:59
1

You can also do `$an_array = array();` which loosely evaluates to false. – AbraCadaver Apr 12 '19 at 19:59
AbraCadaver, THANKS, good idea. didnt even come up with this. – Stef Apr 12 '19 at 19:59
Or even cast `array_key_exists("key", (array)$an_array)`, but it's better to give what you need or test for expected. – AbraCadaver Apr 12 '19 at 20:00
Here's a better way to do it: error_reporting(0); @ini_set('display_errors', 0); ;) – Lulceltech Apr 12 '19 at 20:11
1

@TimHinz I don't know why that is better. Considering `@` sets error reporting for the line to 0, it does effectively the same as `error_reporting(0);` limited to the line it is on. – Charlotte Dunois Apr 13 '19 at 00:16
@CharlotteDunois it was sarcasm... lol – Lulceltech Apr 15 '19 at 12:59

Is it considered "bad practice" to use "@" to avoid errors?

0 Answers0