Android SQLite Update not working

Question

I am trying to update one column for any number of rows.

Here is the function:

public void setAwardsSyncComplete(String[] ids) {

    String inArray = StringUtils.separateCommas(ids);
    db.beginTransaction();

    try {
        ContentValues contentValues = new ContentValues();
        contentValues.put(COL_SYNCED, true);

        int rowsAffected = db.update(TABLE, contentValues, COL_ID + " IN (" + inArray + ")", null);

    } catch (Exception e) {

        DebugLog.e("Error in transaction", e.toString());
    } finally {

        db.endTransaction();
    }
}

What is strange is that the rowsAffected returns correctly (i.e. rowsAffected > 0), but the column values remain null.

Am I overlooking something very simple here?

Thanks.

score 8 · Accepted Answer · answered Apr 07 '11 at 02:29

8

As you're using transactions, you need to call db.setTransactionSuccessful(); at the end of the try clause. Without this, the update gets rolled back.

See SQLiteDatabase.beginTransaction

Hope this helps,

Phil Lello

answered Apr 07 '11 at 02:29

Phil Lello

8,377
2
25
34

score 2 · Answer 2 · answered Apr 07 '11 at 02:27

2

You need to call db.setTransactionSuccussful() after db.update otherwise any changes will be rolled back when you call endTransaction().

answered Apr 07 '11 at 02:27

Joseph Earl

23,351
11
76
89

kharles · Answer 3 · 2011-04-07T02:32:52.780

1

there's no explicit boolean type in sqlite tables? what data type is the COL_SYNED column you are trying to update?

and you will need to call db.setTransactionSuccussful()

edited Apr 07 '11 at 02:32

answered Apr 07 '11 at 02:25

kharles

326
5
14

score 0 · Answer 4 · answered Apr 07 '11 at 02:39

I think there is a problem on your update..

You need to loop your array and update each one by one..

    private int _rowsAffected;

    foreach (var a in inArray)
    {

    _rowsAffected= db.update(TABLE, contentValues, COL_ID + " = (" + a +")", null);

    }

    db.Commit();
    db.setTransactionSuccussful(); 


if(_rowsAffected > 0)
//Success

Regards

Android SQLite Update not working

4 Answers4

Linked