Java,Read file content to arraylist

Question

I am reading a file content to ArrayList so I can later manipulate the data. But when I try to print to console the content is repeatedly displayed. I online want to be able to print the five lines. How can i adjust the code so that when i display on the console it can only display the five lines with repeatedly displaying the results? In the file I have

After reading to list and display to console the result is

I only want to display the five lines.

Code:

public void testread(){
    System.out.println("Enter filename:\n");
    String filename=Keyboard.readInput();
    File myfile=new File(filename);
    try (BufferedReader scanfile=new BufferedReader(new FileReader(myfile))) {
        String str;
        List<String>list=new ArrayList<String>();

        while ((str=scanfile.readLine())!=null) {
            int i;
            list.add(str);

            for (i=0; i<list.size(); i++) {
                System.out.println(list.get(i));
            }
        }
    } catch (IOException e) {
        System.out.println("Error reading from file " + e.getMessage());
    }
}

Possible duplicate of [Java reading a file into an ArrayList?](https://stackoverflow.com/questions/5343689/java-reading-a-file-into-an-arraylist) — Samuel Philipp, Apr 23 '19 at 18:24

score 1 · Accepted Answer · edited Apr 23 '19 at 23:51

You need to move your print for loop out of your while loop. Each iteration of your while loop is then printing every value in the list. Like so:

public void testread(){

    System.out.println("Enter filename:\n");
    String filename=Keyboard.readInput();
    File myfile=new File(filename);
    try(BufferedReader scanfile=new BufferedReader(new FileReader(myfile))){
        String str;
        List<String>
        list=new ArrayList<String>();
        while((str=scanfile.readLine())!=null)
        {
            int i;
            list.add(str);
        }
        // then print the list
        for(i=0;i<list.size();i++) {
            System.out.println(list.get(i));
        }
    }catch (IOException e){
        // Print error in case of failure.
        System.out.println("Error reading from file " + e.getMessage());
    }
}

score 0 · Answer 2 · edited Apr 23 '19 at 18:28

Just move the for loop outside the while loop.

public void testread(){
    System.out.println("Enter filename:\n");
    String filename=Keyboard.readInput();
    File myfile=new File(filename);
    try (BufferedReader scanfile=new BufferedReader(new FileReader(myfile))) {
        String str;
        List<String>list=new ArrayList<String>();

        while ((str=scanfile.readLine())!=null) {
            int i;
            list.add(str);
        }

        for(i=0;i<list.size();i++) {
            System.out.println(list.get(i));
        }
    } catch (IOException e) {
        System.out.println("Error reading from file " + e.getMessage());
    }
}

Java,Read file content to arraylist

2 Answers2