0

I built the python code that can find the sentence that is in another sentence as below, but it didn't work well.

sentence = "While speaking to Ross, Rachel comes to terms with something that was bothering her."
if "Rachel has made coffee to Joey and Chandler for the first time of her entire life." or "Monica can't stop smiling while having a conversation with Rachel." in sentence:
    print("YES")
else
    print("NO!")

It should be printed "NO!" because it has totally different sentence. However, it prints "YES"..

Is this because of string?

Is there anything I did wrong in my code or

Do I misunderstand something?

Zoe
  • 27,060
  • 21
  • 118
  • 148
paulc1111
  • 631
  • 3
  • 14
  • 32
  • It's evaluating the first sentence before the `or` as True, and returning. – CasualDemon Apr 29 '19 at 15:16
  • 1
    Possible duplicate of [Check if multiple strings exist in another string](https://stackoverflow.com/questions/3389574/check-if-multiple-strings-exist-in-another-string) – Joe Apr 29 '19 at 15:21

4 Answers4

8

You are not using the or correctly you should - 

if "Rachel has made coffee to Joey and Chandler for the first time of her entire life." in sentence or "Monica can't stop smiling while having a conversation with Rachel." in sentence:

The if condition returns False if the variable is None or empty list or empty string or empty set or empty dictionary (...) and True otherwise.

Tom Ron
  • 5,906
  • 3
  • 22
  • 38
1

Your problem is, that or is a boolean operator. It does not operate on Strings, but on expressions like string in string. Try something like this: 

if ("Rachel has made coffee to Joey and Chandler for the first time of her entire life." in sentence)or ("Monica can't stop smiling while having a conversation with Rachel."     in sentence):
Zoe
  • 27,060
  • 21
  • 118
  • 148
Robb
  • 139
  • 4
1

Take a look at this example:

if "some string":
  print("YES")
else:
  print("NO")

if you run this in your environment the if clause will always evaluate to True and an output of "YES" will be shown.

Why? Because the string is not being compared to anything and therefore can never be evaluated as a False statement

Now let's take a look at the if clause in your code(With minor formatting changes):

sentence = "While speaking to Ross, Rachel comes to terms with something that was 
bothering her."

text1 = "Rachel has made coffee to Joey and Chandler for the first time of her entire life."

text2 = "Monica can't stop smiling while having a conversation with Rachel."

if (text1) or (text2 in sentence):
    print("YES")
else:
   print("NO")

When using the logical or operator the if clause evaluates as True if either or both of the conditions are met.

text1 is not compared to anything and returns True automatically, the program enters the if clause and executes your print statement

Instead we could re-write the code as follows:

if (text1 in sentence) or (text2 in sentence):

We evaluate if text1 or text2 are substrings of sentence.

Zoe
  • 27,060
  • 21
  • 118
  • 148
danny bee
  • 840
  • 6
  • 19
0

Your comparison statement is a bit faulty. You are basically saying this:

if string or other_string in comp_string:

The first part of the conditional 'if string' always evaluates to true. You are not checking whether that string exists in the string you want to compare to, which is why you are always printing 'YES'.

You need to be more explicit. What you want to do is this:

if string in comp_string or other_string in comp_string:

This should evaluate correctly.

seb_rc
  • 43
  • 3