In windows batch file, re-set variable inside if-else block doesn't work

Question

I've got the code below, try to re-set variable "name" inside an if-else block:

@echo off
set name=kk
echo %name%
if "%name%"=="jj" (
echo case1
) else (
echo case2
set name=ll
echo name=%name%
)

Under cmd of win10, it outputs:

aa
kk
case2
name=kk

This is weird, I wish that my last echo should print:

name=ll

Seems the "set name=ll" didn't work. So would you help to explain why it didn't work as I expected, and how to fix it?

Your `set` commands are working fine, the issue you're experiencing is with your use of `%name%`. Possible duplicate of [Variables are not behaving as expected](https://stackoverflow.com/questions/30282784/variables-are-not-behaving-as-expected) — Compo, May 03 '19 at 07:57
if you don't want to `enabledelayedexpansion` as shown by numerous duplicate questions on SO, then you can use `call echo name=%%name%%` — Gerhard, May 03 '19 at 08:24

score 3 · Accepted Answer · answered May 03 '19 at 05:38

3

You need a delayed expansion

@echo off
setlocal enableDelayedExpansion
set name=kk
echo %name%
if "%name%"=="jj" (
  echo case1
) else (
  echo case2
  set name=ll
  echo name=!name!
)

answered May 03 '19 at 05:38

npocmaka

55,367
18
148
187

In windows batch file, re-set variable inside if-else block doesn't work

1 Answers1