Trying to read text file C++

Question

Using Dev C++, we are trying to get the code to read it one line at a time and store it in an array. We don't seem to get any official errors, but a windows box pops onto the screen to find a solution for the errors?

#include <iostream>
#include <fstream>
#include "AddressBook.h"

const int ADDR_BOOK_SZ  = 1000;

void AddNewAddressBook(AddressBook* current);
void PrintAddresses(AddressBook* addrBook);

using namespace std;
int main(int argc, char** argv) {
    AddressBook addrBook[ADDR_BOOK_SZ];
    AddressBook* current;
    char* path;
    ifstream file;
    char* placeholder;
    bool running = true;
    char entered;
    while(running) {
        //print directions
        cout << "a) Open an address book file\n" 
        << "b) Add a new address book entry\n" 
        << "c) Print the contents of current address book\n" 
        << "d) Quit" << endl;

    //get the user's command
    cin >> entered;

    //set pointer to the current addressbook
    current = addrBook + AddressBook::entryCnt_;

    if(entered == 'a') {
         cout << "Please enter the file path for the address book file: " << '\n';
          cin >> path;
          file.open(path);
          int i = 0;
          while(!file.eof()){

              //getline(placeholder, 100);
              file >> placeholder;
              addrBook[i].SetFirstName(placeholder);
              file >> placeholder;
              addrBook[i].SetFirstName(placeholder);
              file >> placeholder;
              addrBook[i].SetStreetNum((int)placeholder);
              file >> placeholder;
              addrBook[i].SetStreetName(placeholder);
              file >> placeholder;
              addrBook[i].SetCity(placeholder);
              file >> placeholder;
              addrBook[i].SetState(placeholder);
              file >> placeholder;
              addrBook[i].SetZipCode((int)placeholder);            
              i++;      
          }
    } 
    else if(entered == 'b') {
        current->AddEntryFromConsole();

    }
    else if(entered == 'c') {
        for(int i = 0; i < AddressBook::entryCnt_; i++) {
            addrBook[i].PrintToConsole();
        }
    }
    else if(entered == 'd') {
        return 0;
    }
    else {
        cout << "Wrong input entered. Try again." << endl;
    }
}
file.close();

}

Thank you for any and all help!

To just read lines and put them into an array, see the answers to: http://stackoverflow.com/q/1567082/179910 — Jerry Coffin, Apr 11 '11 at 04:44

score 1 · Answer 1 · answered Apr 11 '11 at 04:26

1

What does ifstream::operator>> do to an unitialized char* (or an initiazized char* for that matter). I would guess you want a string instead of a char*==right now I think you're reading into random memory.

So, to be clear, try replacing

char* path;

with

string path

and

char* placeholder;

with

string placeholder;

You'll also need to add:

#include <string>

Mind you, this is just based on a quick code review.

answered Apr 11 '11 at 04:26

SirPentor

1,994
14
24

Also, running this code in Visual Studio causes a stack overflow. Any ideas? – Sam Apr 11 '11 at 04:45
Same reason as I said before--the random address that path points to must be on the stack somewhere and when you read into it, you blow away something important. – SirPentor Apr 11 '11 at 05:43

Trying to read text file C++

1 Answers1