Ruby two strings in an IF condition

Question

In my rails project I've if statement with string conditions which doesn't work.

  if shop.details['company_role'] == 'CEO' || 'founder'
        'Other'
      else
        shop.details['customer_kind']
      end
  end

When I've case with company_role = founder it didn't return me 'Other' but customer_kind

You better look at the warning you should receive ` 2.6.2 :002 > a = 'test' => "test" 2.6.2 :003 > if a == 'one' || 'two' 2.6.2 :004?> puts 'Other' 2.6.2 :005?> else 2.6.2 :006?> puts 'Else' 2.6.2 :007?> end (irb):7: warning: string literal in condition Other => nil 2.6.2 :008 > if a == 'one' || false 2.6.2 :009?> puts 'Other' 2.6.2 :010?> else 2.6.2 :011?> puts 'Else one' 2.6.2 :012?> end Else one => nil ` — Yurii Verbytskyi, May 29 '19 at 11:03
And than to https://stackoverflow.com/questions/21060234/ruby-operator-precedence-table ruby precedence table(`==` runs first, than you take if false || 'founder') — Yurii Verbytskyi, May 29 '19 at 11:06
@YuriyVerbytskyi pasting irb sessions in comments rarely works. — Stefan, May 29 '19 at 11:27
@Stefan oh yeah, but it doesn't looks like anybody but PO will be interested in that as an answer( — Yurii Verbytskyi, May 29 '19 at 14:27

score 2 · Accepted Answer · answered May 29 '19 at 15:36

The premise is a little off. The if statement works, but it's not producing the results that you expect. It's basically doing the equivalent of this:

shop.details['company_role'] == 'CEO' # is this true? then stop | "founder" # is this true? yes, it's always truthy

The solutions provided will all work. Your choice mostly depends on your code style. I'd go with the second option because I personally like the test with an emphasis on the tested data.

Two further suggestions. First, the test itself could be extracted to a method. This would improve readability of your code.

def shop_type
  if executive?
    'Other'
  else
    shop.details['customer_kind']
  end
  # alternate: executive? ? 'Other' : shop.details['customer_kind']
end

def executive?
  shop.details['company_role'].in?('CEO','founder')
end

Lastly, it strikes me that the decision about whether or not a Shop includes an "executive?" seems to be useful information in a number of contexts. As such, it looks like the executive? method would be better placed inside the Shop model so that knowledge of the internal organization of the Shop does not leak all over your system.

shop.executive? ? 'Other' : shop.details['customer_kind']

class Shop
  ...
  def executive?
    shop.details['company_role'].in?('CEO','founder')
  end
end

Rajkumar Ulaganadhan · Answer 2 · 2019-05-29T11:03:38.197

1

Try like this,

if ['CEO','founder'].include?(shop.details['company_role'])
  'Other'
else
  shop.details['customer_kind']
end

edited May 29 '19 at 11:03

answered May 29 '19 at 10:35

Rajkumar Ulaganadhan

698
5
12

score 1 · Answer 3 · answered May 29 '19 at 10:44

1

%w(CEO founder).include?(shop.details['company_role']) ? 'Other' : shop.details['customer_kind']

answered May 29 '19 at 10:44

zlei1

19
1

score 1 · Answer 4 · answered May 29 '19 at 10:53

1

if shop.details['company_role'].in?('CEO','founder')
  'Other'
else
  shop.details['customer_kind']
end

answered May 29 '19 at 10:53

Ashish Garg

105
1
9

I've just tried this in Ruby 2.2.2 and the method isn't defined, it may belong to later versions of Ruby, or to a library. – AJFaraday May 29 '19 at 10:56
2

@AJFaraday [`Object#in?`](https://api.rubyonrails.org/classes/Object.html#method-i-in-3F) – this is a Rails question – Stefan May 29 '19 at 11:21
Ahh, I missed that detail. No problem. – AJFaraday May 29 '19 at 13:04
Remove your other answer or combine the 2 answers (and fix the errors in your other answer) – engineersmnky May 29 '19 at 13:24

score 0 · Answer 5 · answered May 29 '19 at 11:37

0

Keep it simple-

if shop.details['company_role'] == 'CEO' || shop.details['company_role'] == 'founder'
        'Other'
else
        shop.details['customer_kind']
end

answered May 29 '19 at 11:37

sm83

15
6

Ruby two strings in an IF condition

5 Answers5