Convert byte array of zeros and ones (0,1) to string of zeros and ones

Asked Jun 19 '19 at 11:29

Active Jun 19 '19 at 11:39

Viewed 534 times

I am trying to convert a big byte array of zeros and one to a string variable.

private Random _random;
private string _str;

private void Convert(byte[] bytes)
{
    for (var index = 0; index < 10000000; index++)
    {
        var b = bytes[index];                
        _str += b.ToString();

    }            
}

But its performance is very low.

Is it possible to convert a big array to string variable with 'unsafe' or 'fixed' keywords? (use memory allocation)

edited Jun 19 '19 at 11:39

asked Jun 19 '19 at 11:29

Milad Hatami

1,494
13
18

Maybe this is an [XY problem](http://xyproblem.info)? – Uwe Keim Jun 19 '19 at 11:31
I have a feeling there's a linq one-liner that can do this, but the simple performance fix to your code is to use a StringBuilder instead of appending to an ordinary string. – 500 - Internal Server Error Jun 19 '19 at 11:31
1

Why did you remove relevant code? Anyway, use a stringbuilder, not `string += string`. – CodeCaster Jun 19 '19 at 11:31
Perhaps `String.Join("", bytes.Select(x => Convert.ToString(x, 2)))`? – haim770 Jun 19 '19 at 11:32
And when you use a string builder you can exactly set the initial buffer size. – Alex K. Jun 19 '19 at 11:34
1

@CodeCaster 'stringbuilder' worked for me. – Milad Hatami Jun 19 '19 at 12:18

Convert byte array of zeros and ones (0,1) to string of zeros and ones

0 Answers0