PHP cannot access public variable inside of switch

Question

OK, so I have a class called user. In that class, I have a couple of public variables like "key" (Used for encryption). Also a couple of functions but the only relevant one is get_all(). This function gets all data from a database and stores it in these public variables (So I can access them from another class).

class User
{

    public $uuid = "";
    public $key = "";

    public function get_all()
    {
        $db = mysqli_connect('localhost', 'root', 'password', 'BOTNET');

        $sql = $db->prepare("SELECT * FROM USERS WHERE uuid=?");

        $sql->bind_param('s', $this->uuid);

        if ($sql->execute())
        {
            if ($all_info = $sql->get_result()) // This fails
            {
                while ($row = $all_info->fetch_assoc())
                {   
                    $this->key = $row["_Key"];
                    ...
                }

            }

            error_log("ERROR"); // Gets logged
            error_log(mysqli_error($db)); // This doesnt log anything

        }
}

Now to the problem: I have a second file lets say index.php in there I access the user class in the following way:

$user = new User();
$user->set_uuid(some_uuid);
$user->get_all(); (Set all public variables)
$key = $user->key; (Now I should have a string with the users key, but no: $key is just empty)

This exact code works in different classes, and when it's outside of the switch

The switch:

switch ($_POST["action"])
{
    case 1:
        $user = new User();
        $user->set_uuid(some_uuid);
        $user->get_all(); (Set all public variables)
        $key = $user->key; (Now I should have a string with the users key)
        break;
    ...
  }

sry forgot to add the $this (I manually wrote the code her and simply forgot to add it) — Johannes Meyer, Jun 20 '19 at 16:11
in the switch statement, you have `$User->key`, in upper-case, but you defined `$user` in lower key. Not sure if it's a typo on SO or in the original code. — farhang, Jun 20 '19 at 16:14
@Dharman It's good to refer the user to that question, but it's hardly a duplicate. Otherwise almost every question about using SQL from PHP would be a duplicate of that, since SQL-injection vulnerability is rampant. — Barmar, Jun 20 '19 at 16:22
@Dharman His problem is just that he mistyped a variable name, it has nothing to do with the functions he's using to perform the query. — Barmar, Jun 20 '19 at 16:30
There are probably better duplicates for the "forgot to call mysqli_query" error than the "how to prevent SQL injection" question. But questions like this aren't really much use, so we should just comment about it and close the question as "cannot reproduce". — Barmar, Jun 20 '19 at 16:34
Ok so I updated it to use bind param etc but it fails for some reason. — Johannes Meyer, Jun 20 '19 at 17:20
[How to enable MySQLi exception mode?](https://stackoverflow.com/a/22662582/1839439) — Dharman, Jun 20 '19 at 17:53
I am not even getting any error. BTW if it helps I am using the built-in PHP web server. — Johannes Meyer, Jun 20 '19 at 18:01

PHP cannot access public variable inside of switch

0 Answers0