How can this function be simplified without using the conditional

Asked Jun 27 '19 at 13:29

Active Jun 27 '19 at 13:31

Viewed 26 times

Fairly new to ruby so sorry if it's an easy solve.

I want to verify a 10 digit phone number regardless of formatting using Regex. The function contains a conditional however I think it can be simplified.

eg:

valid_phone = ["2438894546", "(718)891-1313", "234 435 9978", "(800)4261134"]

invalid_phone = ["28894546", "(718)891-13135", "234 43 9978"]

def valid_phone_number?(phone)
   number = phone.scan(/\d/)
   number.length == 10 ? true: false 
end

How do we count the arguments digits regardless of the special characters?

edited Jun 27 '19 at 13:31

Wiktor Stribiżew

607,720
39
448
563

asked Jun 27 '19 at 13:29

Turt koda

1

Nit: the ternary can be replaced by `number.length == 10` – D. Ben Knoble Jun 27 '19 at 13:32
Use `/\A\d{10}\z/` – Wiktor Stribiżew Jun 27 '19 at 13:32
@WiktorStribiżew That won't match `"(718)891-1313"` correctly, as required... – vlumi Jun 27 '19 at 13:33
You could first remove all non-digits, and then match `/^\d{10}$/` – vlumi Jun 27 '19 at 13:34
3

You don't need the ternary there `phone.scan(/\d/).length == 10` – Sebastián Palma Jun 27 '19 at 13:34
@vlumi `number.gsub(/\D+/, '')` and then a check against `/\A\d{10}\z/` will do. Or, `/\A(?:\D*\d){10}\D*\z/` – Wiktor Stribiżew Jun 27 '19 at 13:36
1

No regex: `def valid_phone_number?(phone); phone.count("0-9") == 10 ; end` – steenslag Jun 27 '19 at 14:25

How can this function be simplified without using the conditional

0 Answers0