Python: Printing the sum of all items in a list via functions

Question

My Objective: To find and print the sum of all the items in the list via function

My Code:

def list_sum(x):
    if type(x)!='list':
        print("Invalid List item!")
    if type(x)=='list':
        list_length = len(x)
        total = 0
        i = 0
        for i in range (list_length):
            total +=x[i]
            i+=1
        print("The sum of all items in the list is: ",total)

samples = [1,3,5,6,8,45,67,89]

list_sum(samples)

My Output:

<class 'list'>
Invalid List item!

Expected: 224

Why am I getting the output I am getting?

`type()` does not return a string, so your `type(x)!='list'` test is **always true**. — Martijn Pieters, Jul 15 '19 at 11:25
True guys, I can use the built in function .... but I was kind of playing around. I wanted to create a function from scratch. — srini, Jul 15 '19 at 11:25
replacing `type(x)=='list'` by `type(x)==list` will make your function work — Sebastien D, Jul 15 '19 at 11:25
Next, `for i in range(...)` will set `i` to a new value each loop iteration. Using `i+=1` in the loop is entirely useless. — Martijn Pieters, Jul 15 '19 at 11:26

score 1 · Answer 1 · answered Jul 15 '19 at 11:26

1

if type(x) != list

not

if type(x) != 'list'

answered Jul 15 '19 at 11:26

RaideR

869
1
12
33

Or you could use isinstance(x, list) – Massimo Di Saggio Jul 15 '19 at 11:28

Python: Printing the sum of all items in a list via functions

1 Answers1