Trying to pull json from URL, not working

Question

I'm trying to pull a json file of products from a URL in PHP. I have the following code but it's not working. Can somebody please advise where I've gone wrong?

function getJson() {
$request = file_get_contents('https://3rdParty.guntrader.uk/ShootingSuppliesLtd/jsonGuns');
$json = json_decode($request);
return $json;
};

echo $json;

Undefined variable: json in C:\Users\darry\dev\VVV\www\ssheadless\importJson.php on line 36

Don't change your question. That invalidates the existing answers and the duplicate. If you have a new question, [ask a new question](https://stackoverflow.com/questions/ask). — Ivar, Jul 17 '19 at 14:55

MH2K9 · Answer 1 · 2019-07-17T12:48:08.837

2

You didn't call the method getJson(). Without calling a method the return value can't be accessed. Call the method.

function getJson() {
    $request = file_get_contents('https://3rdParty.guntrader.uk/ShootingSuppliesLtd/jsonGuns');
    $json = json_decode($request);
    return $json;
};

echo getJson();

edited Jul 17 '19 at 12:48

answered Jul 17 '19 at 12:46

MH2K9

11,951
7
32
49

Yep, $json is local variable, available only inside getJson() function. Not in global scope. – MilanG Jul 17 '19 at 12:47
Of course, thank you. – Darryl Morley Jul 17 '19 at 12:54
I'm now getting 'Recoverable fatal error: Object of class stdClass could not be converted to string' does this mean an issue with the json format? – Darryl Morley Jul 17 '19 at 12:59
I've sorted it now, thanks for the help, new to PHP. I had to use print_r to view the contents of the array. – Darryl Morley Jul 17 '19 at 13:04

Trying to pull json from URL, not working

1 Answers1