Momentjs, Property 'toISOString' does not exist on type '{}'

Question

I have the following code which worked until now but now value.toISOString() throws a compiler error. I have upgraded from Angular 7 -> 8 which brought with itself an upgrade to Typescript 3.4.5. Any idea what is causing this?

    import * as moment from 'moment';    
    ...

    private getQueryStringParameters(parameters: any) {
        if (!parameters) {
            return '';
        }

        let queryString = '?';

        // tslint:disable-next-line:forin
        for (const key in parameters) {
            const value = parameters[key];

            if (value !== undefined) {
                if (value instanceof Array) {
                    value.forEach(
                        item =>
                            (queryString +=
                                key + '=' + encodeURIComponent('' + item) + '&')
                    );
                } else if (value instanceof moment) {
                    queryString +=
                        key +
                        '=' +
                        encodeURIComponent('' + value.toISOString()) +
                        '&';
                } else {
                    queryString +=
                        key + '=' + encodeURIComponent('' + value) + '&';
                }
            }
        }

Thanks in advance for any input!

Out of curiosity, why would you write a `getQueryStringParameters` function in the first place, instead of relying on Angular's own methods of forming the query params string out of an object (both for Angular Router and HttpClient)? — mbojko, Jul 17 '19 at 14:16
check this answer: https://stackoverflow.com/a/38330983/2050306 — robert, Jul 17 '19 at 14:17
@robert Thanks, changing it to that fixed the compile problem. If you add it as an answer I'll accept it. — Botond Béres, Jul 17 '19 at 14:58
@mbojko I'm not sure, I didn't write this code. But I'll look into it. — Botond Béres, Jul 17 '19 at 14:59

score 1 · Accepted Answer · answered Jul 17 '19 at 20:32

1

Instead of:

value instanceof moment

Try using isMoment method:

moment.isMoment(value)

See the docs and stackblitz demo.

answered Jul 17 '19 at 20:32

robert

5,742
7
28
37

Momentjs, Property 'toISOString' does not exist on type '{}'

1 Answers1