Why doesn't the if statement print 'well done' and why does the loop repeat out questions()

Question

I wanted to make a game where in which you get three turns to guess the selected number, from the computer. However it will never say well done even if you get the number right (already tested using printf statements) and the loop will also mess up by either continuing or running twice.

I've tried removing the break. I've put in printf statements to check if randomise and questions actually store the correct values and they do.

# include <stdio.h>
# include <stdlib.h>
# include <math.h>
# include <time.h>

int questions() {

    int num;

    printf("Chose a number between one - ten: ");
    scanf("%d",&num);

    return num;

}

int randomise() {

    int roll;

    srand(time(NULL));

    roll = rand()%10 + 1;
    return roll;

}

int main() {

    int chosenNum, enteredNum, i;

    chosenNum = randomise();
    enteredNum = questions();

    for(i = 0; i < 10; i++) {
        if(chosenNum != enteredNum) {

            questions();
            break;

        }
        else if(chosenNum == enteredNum) {

            printf("WELL DONE !!!");

        }
    }

    return 0;
}

Zero errors and Zero warnings. and the outcome should be that you get greeted with well done.

That shouldn't be too short of text, but try adding a `"\n"` to the end of the message: `"WELL DONE !!!\n"`. — Carcigenicate, Aug 17 '19 at 22:47
`chosenNum = questions();` and the `break` is in the wrong branch... — Antti Haapala -- Слава Україні, Aug 17 '19 at 22:50
Note [`srand()` — why call it only once?](https://stackoverflow.com/questions/7343833/). It isn't directly your problem here since you only call `randomise()` once. But it is something you need to pay attention to very soon. Your 'Well Done' message should end with a newline. — Jonathan Leffler, Aug 18 '19 at 00:10
Thankyou for your comments, I have used all your feedback and will post the code shortly.Thankyou — Ash, Aug 18 '19 at 21:46

score 1 · Answer 1 · edited Aug 18 '19 at 00:14

1

There are two issues:

You are using break which will not allow another attempt to input the number if first number is not matched, and
the return value from questions() in the loop is not assigned to enteredNum (it means it will try old number second time).

edited Aug 18 '19 at 00:14

Jonathan Leffler

730,956
141
904
1,278

answered Aug 17 '19 at 23:07

ChauhanTs

439
3
6

Thankyou for your feedback, I have taken it on board and it now works perfectly. Cheers – Ash Aug 18 '19 at 21:48

score 0 · Accepted Answer · answered Aug 17 '19 at 22:52

0

enteredNum is never set inside the loop. Thus, it's impossible for the if be false unless it is false the first time.

Fix your loop to something like this instead:

for(i = 0; i < 10; i++){
 if(chosenNum != enteredNum){

    enteredNum = questions();
    break;

   }
   else if(chosenNum == enteredNum){

      printf("WELL DONE !!!");

   }
}

answered Aug 17 '19 at 22:52

But the `break` isn't wanted. – Jonathan Leffler Aug 18 '19 at 00:13

score 0 · Answer 3 · answered Aug 18 '19 at 23:12

This is the most recent update of the code, thanks for all your help guys. The feedback was great ! Heres the code:

#include <stdio.h>
#include <stdlib.h>
#include <math.h>
#include <time.h>

int questions(){

int num;

printf("Chose a number between one - ten: ");
scanf("%d",&num);

return num;

}

int randomise() {

int roll;

srand(time(NULL));

roll = rand()%10 + 1;

return roll;

}

int main(){

int chosenNum, enteredNum, i;

int life = 3;

chosenNum = randomise();
enteredNum = questions();

for(i = 0; i < 2; i++){

enteredNum = questions();

 if((enteredNum != chosenNum) && life > 0){

    life -= 1;

    if(life == 1 ){

    printf("GAME OVER !!!\n");
    break;

      }

    }
    else if((chosenNum == enteredNum) && life > 0){

    printf("WELL DONE !!!\n");
    break;

   }

}

return 0;

}

Why doesn't the if statement print 'well done' and why does the loop repeat out questions()

3 Answers3