What could be the problem with inserting the query from localhost database?

Question

I am working on getting active users on a localhost server. While I came up with an error. I am providing the portion which is not working in PHP MySQL:

I changed $REMOTE_ADDR, $PHP_SELF to $_SERVER['$REMOTE_ADDR'], $_SERVER['PHP_SELF'] as those are old version of PHP. Still not getting expected result.

$timestamp = time();

//insert the values
$insert = mysql_db_query($database, " INSERT INTO mytable VALUES('$timestamp', $_SERVER['$REMOTE_ADDR'], $_SERVER['PHP_SELF'] )" );

the error goes like this:

Parse error: syntax error, unexpected '' (T_ENCAPSED_AND_WHITESPACE), expecting identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in G:\xampp\htdocs\jencyphp\liveonline\online.php on line 21

Did you try an online sql validator, e.g. https://www.eversql.com/sql-syntax-check-validator/? — jasie, Aug 28 '19 at 09:59
Stop using `mysql_*()`, it's deprecated. Use mysqli or PDO instead. — Raptor, Aug 28 '19 at 10:05
Although you should use prepared statements, try building the string by concatanation... `'$timestamp', '". $_SERVER[$REMOTE_ADDR]."` — Nigel Ren, Aug 28 '19 at 10:05
I am looking for a solution... Glad as it was duplicate... Nigel Ren Appreciate your help. Found my solution — Jency, Aug 28 '19 at 10:05

Rajdip Chauhan · Answer 1 · 2019-08-28T10:10:20.287

0

Can you please check by doing this. You are missing database table fields name in query so you must need to add that fields.

$timestamp = time();

$insert = mysql_db_query($database, "INSERT INTO mytable (`field1`,`field2`,`field3`) VALUES('".$timestamp."','".$_SERVER['REMOTE_ADDR']."','".$_SERVER['PHP_SELF']."')");

edited Aug 28 '19 at 10:10

answered Aug 28 '19 at 09:53

Rajdip Chauhan

345
2
11

Checking...2 minutes – Jency Aug 28 '19 at 09:55
No Luck ....... – Jency Aug 28 '19 at 09:58
It's still the same error..... – Jency Aug 28 '19 at 10:01
Although I would usually add the column names in to ensure the values go in the right fields, they are not necessary. – Nigel Ren Aug 28 '19 at 10:06
@Jency : I have updated answer. check it now. it will work for you. – Rajdip Chauhan Aug 28 '19 at 10:10

What could be the problem with inserting the query from localhost database?

1 Answers1