How can I extract from a regex

Question

I would like to extract urls from a regex (not all urls, only some via my regex).

I tried Regex.Match

string html = request.Get(
    "http://www.bing.com/search?q=" + keyword + "&first=1"
).ToString();
Match urls = Regex.Match(html, "<h2><a href=\"(.*?)\"");

it only displays one URL, I would like to have all the URLs

EDIT : for people who have had this problem, here is the solution

string pattern = @"<a href=""([^""]+)";
                                Regex rgx = new Regex(pattern);

                                foreach (Match match in rgx.Matches(html))
                                    Console.WriteLine("Found '{0}' at position {1}", match.Value, match.Index);

Should be `Regex.Matches` I believe. ref : https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.matches?view=netframework-4.8 — Cuppyzh, Aug 30 '19 at 18:49
Is there a reason you're not using an HTML parser and finding the `a` elements by their location within the document or by their properties? — madreflection, Aug 30 '19 at 19:13
Other possible duplicates or solutions: [regular expression for finding 'href' value of a link](https://stackoverflow.com/q/15926142), [regex c# extracting url from tag](https://stackoverflow.com/q/42118366). — dbc, Aug 30 '19 at 21:43

Michał Turczyn · Accepted Answer · 2019-08-30T20:18:39.840

0

In order to get all URLs you would need to remove <h2> tag.

Try pattern: <a href="([^"]+)

Explanation:

<a href=" - match literally <a href="

([^"]+) - match one or more of characters other than " and store it into first capturing group

In order to get all URLs you need to call Matches method and then loop through them using Groups property:

foreach(var match in Regex.Matches(html, "<a href=\"([^\"]+)")
{
  // get url from first capturing group
  string url = match.Groups[1];
  // ...
}

edited Aug 30 '19 at 20:18

answered Aug 30 '19 at 19:08

Michał Turczyn

32,028
14
47
69

thank you ! but look, the regex don't work https://i.imgur.com/h0Uweht.png i can make a screenshot of the errors but my Visual Studio is in French langage – mr spysix Aug 30 '19 at 19:18
You need `@` (missing in the answer) on the string to escape quote characters that way: `@" – madreflection Aug 30 '19 at 19:23
okay thanks ! but the match.Groups dont work (error CS1061) – mr spysix Aug 30 '19 at 19:29
@madreflection its good, thank you – mr spysix Aug 30 '19 at 19:34
@mrspysix Try updated answer. – Michał Turczyn Aug 30 '19 at 20:19
2

@mrspysix You should accept the answer if it has helped you instead of posting it in an answer :) – Michał Turczyn Aug 30 '19 at 20:20
@MichałTurczyn how ? sorry – mr spysix Aug 31 '19 at 11:03
@mrspysix By checking green check mark on the left side of an answer. – Michał Turczyn Aug 31 '19 at 12:22
@MichałTurczyn okay its good – mr spysix Aug 31 '19 at 18:04

How can I extract from a regex

1 Answers1