Arr.map returns null instead of removing object completely?

Question

I am trying to remove each user that does not have a firstName and lastName.

This is the object:

users = [{firstName: "john", lastName: "smith"}, {firstName: "", lastName: ""}]

This is my code:

let users = this.users.map(user => {
        if (user.firstName !== '' && user.lastName !== '') {
          return user
        }
})

It does remove the empty ones, but it replaces it with null, and I want to completely remove it and not display null instead of the object.

What I get when I log it the mapped array: [{firstName: "john", lastName: "smith"}, null]

well map does not remove indexes... – epascarello Sep 04 '19 at 18:08 — epascarello, Sep 04 '19 at 18:08

DjaouadNM · Accepted Answer · 2019-09-04T18:15:58.887

3

You should use a filter, not a map, a map simply applies some transformation on the elements, filter, however, is suitable for removing/keeping elements based on certain conditions:

var users = [{firstName: "john", lastName: "smith"}, {firstName: "", lastName: ""}]

users = users.filter(user => (user.firstName !== '' && user.lastName !== ''));

console.log(users);

edited Sep 04 '19 at 18:15

answered Sep 04 '19 at 18:08

DjaouadNM

22,013
4
33
55

DontVoteMeDown · Answer 2 · 2019-09-04T18:09:19.533

1

Use filter() instead:

let users = this.users.filter(user => (user.firstName !== '' && user.lastName !== ''));

edited Sep 04 '19 at 18:09

answered Sep 04 '19 at 18:07

DontVoteMeDown

21,122
10
69
105

You code sample is not using filter. – epascarello Sep 04 '19 at 18:09
@epascarello yeah my bad. – DontVoteMeDown Sep 04 '19 at 18:09

Arr.map returns null instead of removing object completely?

2 Answers2