MySQL not inserting data from php

Question

I’m having some problems with my database.

MySQL database is organized as:

——————————————————————
userId | value
——————————————————————
63     | {"pro":true}

The GET requests are working just fine but not the POST requests. POST requests return me just nothing, when it should return a JSON with a success index.

This is my index.php code:

<?php
    $database = "";
    $username = "";
    $password = "";
    $servename = "localhost";

    $connection = new mysqli($servername, $username, $password, $database);

    if ($connection->connect_error) {
        die("Connection failure: ".$connection->$connection_error);
    }

    header("Content-type: application/json");

    if ($_SERVER["REQUEST_METHOD"] == "GET") {
        if ($_GET["userId"]) {
            $result = $connection->query("SELECT value FROM main_table WHERE userId = ".$_GET["userId"]);
            if ($result->num_rows > 0) {
                echo $result;
            }
            else {
                echo json_encode(array());
            }
        }
    }
    elseif ($_SERVER["REQUEST_METHOD"] == "POST") {
        if ($_POST["userId"] && $_POST["value"]) {
            $result = $connection->query("INSERT INTO main_table (userId, value) VALUES ('".$_POST["userId"]."', '".$_POST["value"]."')");
            if ($result) {
                echo json_encode(array("success" => TRUE));
            }
            else {
                echo json_encode(array("success" => FALSE));
            }
        }
    }

    $connection->close();
?>

Could you guys spot any mistakes in my code?

Thank you in advance!

@NigelRen oh, yes. Just fixed that. The problem still persists though. — Octonions, Sep 07 '19 at 11:41

dılo sürücü · Answer 1 · 2019-09-07T12:27:59.157

1

your code is not secure ,Use this to avoid sql injection

Simple you can should as below code ..also better safety

For select


$query = "
    SELECT *
    FROM main_table
    WHERE userId= ?
";
$stmt = $connection->prepare($query);


$userId=$_GET["userId"];

$stmt->bind_param("i", $userId);

$result = $stmt->get_result();

$rows=[];
while ($data = $result->fetch_assoc())
{
    $rows[] = $data;
}

echo json_encode($rows);

Insert for example


$stmt = $connection->prepare("INSERT INTO main_table (value,userId) VALUES (?, ?)");
$stmt->bind_param("ii", $_POST['value'], $_POST['userId']);
if($stmt->execute())

{
  echo "insert successful";

}
else
{

 echo "couldn't insert successful";

}
$stmt->close();

edited Sep 07 '19 at 12:27

answered Sep 07 '19 at 11:59

dılo sürücü

3,821
1
26
28

If want insert example I can write – dılo sürücü Sep 07 '19 at 12:15
Be careful data type and data size ,if not compatible you can't insert – dılo sürücü Sep 07 '19 at 12:16
1

@dılosürücü please avoid such condiions like `if($stmt->execute())` - they are unhelpful and confusing. Please see [how to report errors in PHP properly](https://phpdelusions.net/articles/error_reporting). – Your Common Sense Sep 07 '19 at 12:59
You do not need a loop at all. Simply use `fetchAll()` – Dharman Sep 07 '19 at 15:59

MySQL not inserting data from php

1 Answers1