1

I am looking to get this query from this url 'http://localhost:3000/#/quote/edit/?quote_number=1&line_number=1' from this route in express

router.route('/quote/:quote_number&:line_number')
.get(checkAuthentication, (req, res) => {
  let request = new sql.Request(pool)
  let get_lines_query = `
  select *
  from quote_line
  where quote_number = ${req.query.quote_number} and
  line_number = ${req.query.line_number}`

but it is calling a different query from 

route router.route('/quote/:quote_number')
Houshman85
  • 72
  • 6
  • for query params (everything after the `?` you need to use `req.query` like in https://stackoverflow.com/a/6912872/1309377 `:quote_number` is a path parameter – Andrew Lohr Sep 17 '19 at 15:51

2 Answers2

3

Firstly, the URL you provided doesn't match the route. Your route is to /quote/number&line but your URL is of the form /quote/edit/?quote_number=number&line_number=line.

Secondly, parameters written as ?key=value&key2=value2 are called query parameters, and being special, standard forms of parameters, you don't need to bind them yourself. Express will parse them into the req.query object without you specifying the bindings. So all you need to do is change your route to /quote/edit and you're good.

On an unrelated note, please don't directly stick URL parameters into your SQL query. That's how you end up with SQL injection attacks. Depending on the SQL package you're using, there should be a way to use bound parameters in your queries instead.

IceMetalPunk
  • 5,476
  • 3
  • 19
  • 26
0

Try updating your code to:

router.route('/quote/:quote_number/:line_number').get(function (req, res) {
let quote_numer = req.params.quote_number;
let line_number= req.params.line_number;
  res.send(quote_numer  + "" + line_number)
})
Taffarel Xavier
  • 381
  • 5
  • 11