How to remove the last comma from foreach loop?

Question

I am trying to remove the last comma(,) from foreach loop in php with the following code

<?php

foreach ($snippet_tags as $tag_data) {
    $tags_id = $tag_data->tag_id;
    $tagsdata = $this->Constant_model->getDataOneColumn('tags', 'id', $tags_id);
    $tag_name=$tagsdata[0]->tag_name;
?>

<a href="<?= base_url() ?>tags/<?php echo $tag_name; ?>"><?php echo $tag_name; ?></a> ,       

<?php } 
?>

Right I am getting result like

Hello, How, sam,

But i wants to remove the last comma

@u_mulder Did you properly check? my question related to the question what you linked? — Upasana Chauhan, Sep 24 '19 at 14:42
@u_mulder Better you please give the answer and let us know how its related to the question what you linked to — Upasana Chauhan, Sep 24 '19 at 14:45
@RiggsFolly Should I push the variable in a string array and separate them by comma and again rtrim them? — Upasana Chauhan, Sep 24 '19 at 14:51
@RiggsFolly Can you give the answer as I am getting array to string conversion error. — Upasana Chauhan, Sep 24 '19 at 15:02
Check accepted answer, this will help u https://stackoverflow.com/questions/6092054/checking-during-array-iteration-if-the-current-element-is-the-last-element you can use last key here, store last key of your array before foreach then check inside the loop if key is equal to stored last key, avoid to add comma other wise add. — devpro, Sep 24 '19 at 15:07
@RiggsFolly With your answer still getting comma after result — Upasana Chauhan, Sep 24 '19 at 15:08
easy solution: save your link in a string and then create an array of links then simply use `implode(' ,' $links_arr)` — Umer Abbas, Sep 24 '19 at 15:10
check this link also, this is an another solution. https://stackoverflow.com/questions/6092054/checking-during-array-iteration-if-the-current-element-is-the-last-element — devpro, Sep 24 '19 at 15:15
@RiggsFolly when i am using .= getting Undefined variable: out error — Upasana Chauhan, Sep 24 '19 at 15:18
replace all your code with this. `tag_id; $tagsdata = $this->Constant_model->getDataOneColumn('tags', 'id', $tags_id); $tag_name=$tagsdata[0]->tag_name; $tag = "{$tag_name}"; $tags[] = $tag;} $tags = implode(' ,' $tags); echo $tags; ?>` — Umer Abbas, Sep 24 '19 at 15:21

score 1 · Accepted Answer · answered Sep 24 '19 at 15:23

By placing the HTML in a simple string variable and then using rtrim() on the resulting string before outputting it this should remove the final , from the string

<?php
$out = '';

foreach ($snippet_tags as $tag_data) {
    $tags_id = $tag_data->tag_id;
    $tagsdata = $this->Constant_model->getDataOneColumn('tags', 'id', $tags_id);
    $tag_name=$tagsdata[0]->tag_name;

    // move inside loop and amend to place in a simple string var
    $out .= '<a href="' . base_url() . 'tags/' . $tag_name . '">' . $tag_name . '</a>,';
?>

echo rtrim($out, ',');

SM Ataul Karim Riad · Answer 2 · 2019-09-24T15:47:19.573

You can also use the following code -

<?php
$numItems = count($snippet_tags);
$i = 0;

foreach ($snippet_tags as $tag_data) {
   $tags_id = $tag_data->tag_id;
   $tagsdata = $this->Constant_model->getDataOneColumn('tags', 'id', $tags_id);
   $tag_name=$tagsdata[0]->tag_name;
?>

if(++$i === $numItems) 
   echo "<a href='base_url() ?>tags/<?php echo $tag_name;'> $tag_name</a>";
else echo "<a href='base_url() ?>tags/<?php echo $tag_name;'> $tag_name</a> ,";     

<?php 
} 
?>

How to remove the last comma from foreach loop?

2 Answers2