Python function that will find and count vowels in a given string

Question

I am trying to write a code with python that will find and count the number of vowels in any given string. My function prints out 0 vowels no matter what. Any tips?

txt = input("Type text: ").lower()

def findVowels():
    global txt
    vowels = 0
    for letter in txt:
        if letter == 'aeiouy':
            vowels += 1
    return vowels


print(findVowels())

Number of vowels = 0 no matter what

This is may not be code related but technically, "y" is not a vowel. — CodeRed, Oct 02 '19 at 09:00
@CodeRed In English, "y" is considered as a vowel when it is not the first letter of syllable within a word. I.e. it is a consonant in the word "yup", but a vowel in the word "symbol". — James, Oct 02 '19 at 09:02
I'd love to explain but this is not the best platform for that. Good day sir! — CodeRed, Oct 02 '19 at 09:06
In my language, Norwegian "y" is a vowel so that's why it's in there — mikkelven, Oct 11 '19 at 13:29

zipa · Accepted Answer · 2019-10-02T09:00:49.120

4

Try like this:

def findVowels(txt):
    return sum(1 for t in txt if t in 'aeiouy')

edited Oct 02 '19 at 09:00

answered Oct 02 '19 at 08:59

zipa

27,316
6
40
58

Double `def` and you can even do: `return sum(t in 'aeiouy' for t in txt)` – user2390182 Oct 02 '19 at 09:00
Why couldn't you? – creyD Oct 02 '19 at 09:01
@schwobaseggl Thanks for the heads up, and you can, but tends to be slower do to conversion of `bool` to `int`. – zipa Oct 02 '19 at 09:03

score 2 · Answer 2 · edited Oct 02 '19 at 09:20

You are checking if the letter is equal to the entire string 'aeiouy'. Instead check if letter is in the string.

if letter in 'aeiouy':

Also, you can avoid using global variable by passing the input text to the function.

txt = input("Type text: ").lower()

def findVowels(txt):
    vowels = 0
    for letter in txt:
        if letter in 'aeiouy':
            vowels += 1
    return vowels


print(findVowels(txt))

Python function that will find and count vowels in a given string

2 Answers2