Button not leading to desired location

Question

Inside of my tags I have an echo statement which in it has the following line:

"<button style='onclick='window.location.href='https://www.google.com''>Go to Google</button>"

my understanding is that this should make it so that t would bring you to whatever link is in the onclick argument. My button however is not going anywhere when I click it

inside the `onclick` you can only run javascript functions, not `window.location.href` — Ramon de Vries, Oct 11 '19 at 15:27
@RamondeVries That's [not true](https://jsfiddle.net/k7pmc61g/). You can call `window.location.href` in `onClick`event even if it's not best practice. — Jax-p, Oct 11 '19 at 15:31
@Jax-p did they change that recently? i though it wasn't possible back when i learned coding — Ramon de Vries, Oct 11 '19 at 15:36
@RamondeVries I'm not sure - it might depends on script policies on each site. — Jax-p, Oct 11 '19 at 15:38
How is this a "php" question? There isn't really anything showing us how it's used. — Funk Forty Niner, Oct 11 '19 at 15:50

Jax-p · Answer 1 · 2019-10-11T15:34:35.850

0

1st problem: You have onclick event inside of style which is wrong. These are 2 separate attributes. Use only onclick.

2nd problem: You have same quotation marks for all strings (inside/outside). You have to use different for inner arguments.

Valid solution:

<button onclick="window.location.href='https://www.google.com'">Go to Google</button>

Btw. I would rather use <a> instead of <button/>

edited Oct 11 '19 at 15:34

answered Oct 11 '19 at 15:28

Jax-p

7,225
4
28
58

The problem is that this whole thing is inside a php echo statement. That means the whole line has to be inside of ""s and when I keep nesting quatation marks inside of each other it starts to screw it all up – Gabe S. Oct 11 '19 at 15:30
@GabeS. Use a backslash to escape quotation marks. [Escaping quotation marks in PHP](https://stackoverflow.com/questions/7999148/escaping-quotation-marks-in-php) – Jax-p Oct 11 '19 at 15:32

Ramon de Vries · Answer 2 · 2019-10-11T15:42:50.780

0

This should be what you are looking for

EDIT: edited to fit inside php echo,

function gotoPage(link){
window.location.href = "" +link;
}

$link = "hoi";
echo "<button onclick='gotoPage(".$link.")'>Go to Google</button>";

edited Oct 11 '19 at 15:42

answered Oct 11 '19 at 15:30

Ramon de Vries

1,312
7
20

When you put ""s at the front and end of that statement it cancels out the .$link. part. That is the issue I am having – Gabe S. Oct 11 '19 at 15:38
you made the `echo` like this right?: `echo "button link in here"` – Ramon de Vries Oct 11 '19 at 15:39
Yes. It is linking the first quotation mark with the first quote in the gotoPage argument. And the last quotation mark with the second quote in the gotoPage argument – Gabe S. Oct 11 '19 at 15:41
my bad, im changing the anwser once more – Ramon de Vries Oct 11 '19 at 15:41
please try this @GabeS. – Ramon de Vries Oct 11 '19 at 15:43

Button not leading to desired location

2 Answers2