Strong password checker

Question

I am creating a simple code to check if a password is secure. To be secure a password be at least 8 characters and have one special character. My code does not work properly when 8 characters are entered without a special character. How can I fix it?

#get password
password_in = input("Enter a secure password: ")

#check password is secure
special_ch = ['!', '@', '#', '$', '%', '^', '&', '*']

check = any(item in special_ch for item in password_in)

while len(password_in) <8 and check == False: 
    print("Password is not secure") 
    password_in = input("Please enter a secure password: ")

check is not a very good variable name. you should better use something like special_char_used — bb1950328, Oct 15 '19 at 12:54
Possible duplicate of [Regular expression to check if password is "8 characters including 1 uppercase letter, 1 special character, alphanumeric characters"](https://stackoverflow.com/questions/9477906/regular-expression-to-check-if-password-is-8-characters-including-1-uppercase-l) — sahasrara62, Oct 15 '19 at 14:12

score 0 · Accepted Answer · answered Oct 15 '19 at 12:52

Change and to or:

while len(password_in) <8 or check is False: 
    ...

Alternatively, to achieve the same result, put in the exact conditions you're looking for and negate all of it:

while not(len(password_in) >= 8 and check is True):
    ...

The fact that these two are logically equivalent is an example of DeMorgan's Law.

Strong password checker

1 Answers1