RecyclerView not creating items - ( MVVM + Room + LiveData)

Question

RecyclerView items are not getting created - I'm trying to add a note feature (with MVVM+Room+liveData) to my project.

The same code is fine when used in a new android studio project. implementing it in my existing project is the issue. (both are with androidX and have the same implementations).

Other recyclerViews in my app are working correctly (not with MVVM)

The recycler view adapter is not getting accessed - I used Log flags.

The Code source is from here: https://codinginflow.com/tutorials/android/room-viewmodel-livedata-recyclerview-mvvm/part-6-recyclerview-adapter

Note activity:

public class NoteActivity extends AppCompatActivity {

    private NoteViewModel noteViewModel;

    ArrayList<Reviews> reviewList;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_note);

        RecyclerView recyclerView = findViewById(R.id.recycler_view);
        recyclerView.setLayoutManager(new LinearLayoutManager(this));
        recyclerView.setHasFixedSize(true);

        final NoteAdapter adapter = new NoteAdapter();
        recyclerView.setAdapter(adapter);

        noteViewModel = ViewModelProviders.of(this).get(NoteViewModel.class);
        noteViewModel.getAllNotes().observe(this, new Observer<List<Note>>() {
            @Override
            public void onChanged(@Nullable List<Note> notes) {
                adapter.setNotes(notes);
            }
        });
}

Note Adapter:


public class NoteAdapter extends RecyclerView.Adapter<NoteAdapter.NoteHolder> {

    private static final String TAG = "Debug "+NoteAdapter.class.getSimpleName();

    private List<Note> notes = new ArrayList<>();

    @NonNull
    @Override
    public NoteHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
        View itemView = LayoutInflater.from(parent.getContext())
                .inflate(R.layout.note_item, parent, false);
        Log.e (TAG, "in onCreateViewHolder");
        return new NoteHolder(itemView);
    }

    @Override
    public void onBindViewHolder(@NonNull NoteHolder holder, int position) {
        Note currentNote = notes.get(position);
        holder.textViewTitle.setText(currentNote.getTitle());
        holder.textViewDescription.setText(currentNote.getDescription());
        holder.textViewPriority.setText(String.valueOf(currentNote.getPriority()));
        Log.e (TAG, "in onBindViewHolder");
    }

    @Override
    public int getItemCount() {
        return notes.size();
    }

    public void setNotes(List<Note> notes) {
        this.notes = notes;
        notifyDataSetChanged();

    }

    class NoteHolder extends RecyclerView.ViewHolder {
        private TextView textViewTitle;
        private TextView textViewDescription;
        private TextView textViewPriority;

        public NoteHolder(View itemView) {
            super(itemView);
            textViewTitle = itemView.findViewById(R.id.text_view_title);
            textViewDescription = itemView.findViewById(R.id.text_view_description);
            textViewPriority = itemView.findViewById(R.id.text_view_priority);
            Log.e (TAG, "in NoteHolder");
        }
    }
}

the set notes void is the only function getting accessed. (using Log Flags)

The entire code with MVVM classes works in a blank studio project.

What could be the problem??

in Log it get this error:

E/RecyclerView: No adapter attached; skipping layout

try this noteViewModel.getAllNotes().observe(this, ::setData); public void setData(List notes){ adapter.setNotes(notes); } — Kishan Maurya, Oct 17 '19 at 13:12
@KishanMaurya - I get an error for "noteViewModel.getAllNotes().observe(this, ::setData)" what is "::" doing? — SO 80, Oct 17 '19 at 13:19
@KishanMaurya - I get this : "Method references are not supported at language level '7'". — SO 80, Oct 17 '19 at 13:30
instead of this::setData() try list-> setData(list) noteViewModel.getAllNotes().observe(this, list->setData(list)); public void setData(List notes){ adapter.setNotes(notes); } — Kishan Maurya, Oct 17 '19 at 13:34
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/201031/discussion-between-so-80-and-kishan-maurya). — SO 80, Oct 17 '19 at 13:39
Maybe you are not receiving any data in the observer. Try logging inside the observer and see what is the size of `notes`. — Alif Hasnain, Oct 17 '19 at 14:43
@AlifHasnain - adapter.setNotes(notes) is being called, -> the adapter function - public void setNotes is being executed. how do i log an observer? — SO 80, Oct 17 '19 at 14:56
Inside the observer's `onChanged()` method type this `Log.d("TAG" , notes.size());` and see what is the size of the `notes` list in the logcat. — Alif Hasnain, Oct 17 '19 at 15:17

score 0 · Answer 1 · answered Oct 17 '19 at 16:01

The issue is resolved after logging in MVVM components.

I removed the application from my device and installed it again, so the Room database instance was recreated correctly. Apparently, The instance was empty (I don't know why).

btw, this log error is not part of the issue (you can get it when everything is okay) see previously answered question in the link below

E/RecyclerView: No adapter attached; skipping layout

recyclerview No adapter attached; skipping layout

RecyclerView not creating items - ( MVVM + Room + LiveData)

1 Answers1