Check in python if deleting folder was successful and if yes, continue

Question

I am selecting datas from my database, and deleting inactive domains from my filesystem. Sometime, I have domain, which was deactivated twice in database, script will try to delete it also twice, since it's going for each row.

How to fix the issue, when script will find hosting in database, which was on filesystem already deleted, so it will check it's deleted and will continue and not crash on

    os.rmdir('/data/sa/' + name)
FileNotFoundError: [Errno 2] No such file or directory: '/data/sa/test3.com'
masir@linux-hjay:~/Documents/python> ls /data/sa/

Here is my code:

cursor = connection.cursor()
sql="SELECT id, name, state FROM domain WHERE state='2'"
cursor.execute(sql)
records = cursor.fetchall()
print("Total number of records for deleting is: ", cursor.rowcount)

print("\nPrinting each domain record")
for row in records:

    print("id = ", row["id"], )
    print("name = ", row["name"])
    print("state  = ", row["state"], "\n")

    id = row["id"]
    name = row["name"]
    state = row["state"]

    if state == 2:
#       print(state)
        print('found records for deleting' + name)
        os.rmdir('/data/sa/' + name)
    else:
        print('no records for deleting found')
        print('domain', name)
        print('hast state', state, "\n")

you can use `if os.path.exists('filename'): os.rmdir('filename')` — Dan, Oct 21 '19 at 14:05
How to pust multiple arguments to one IF? Since I have condition "if state == 2: .. because state == 2 means deleted hosting.. So I need it in this — Delirium, Oct 21 '19 at 14:07

score 3 · Answer 1 · answered Oct 21 '19 at 14:06

3

You can do the following to check if file/folder exists before trying to remove it:

import os

if os.path.exists("some path"):
    pass
    # remove dir
else:
    print("The dir does not exist")

answered Oct 21 '19 at 14:06

Artiom Kozyrev

3,526
2
13
31

`try-except` is actually better to avoid a race condition, see https://stackoverflow.com/questions/14574518/how-does-using-the-try-statement-avoid-a-race-condition – Chris_Rands Oct 21 '19 at 14:11
1

@Delirium there are many options to combo conditions first option is ```if state == 2 and os.path.exists("some path"): your code```, another option is to put ```if os.path.exist("some path")``` inside ```if state == 2:``` – Artiom Kozyrev Oct 21 '19 at 14:12

Sreejith · Accepted Answer · 2019-10-21T14:09:42.437

1

You can use try/except for this as below, so that script will not get failed at the deleting step.

  if state == 2:
       try:  
#           print(state)
            print('found records for deleting' + name)
            os.rmdir('/data/sa/' + name)
        except Exception as error:
            print("Directory already deleted")
   else:

edited Oct 21 '19 at 14:09

answered Oct 21 '19 at 14:08

Sreejith

434
3
19

And how can I compose "if state == 2" into "try:" ? Edit: oh now I see, thanks! – Delirium Oct 21 '19 at 14:09
1

You mean you want to enclose entire if loop inside try/catch. You can also add separate try catch for that.! – Sreejith Oct 21 '19 at 14:13

score 0 · Answer 3 · answered Oct 21 '19 at 14:16

0

I suggest you to use shutil to remove folders:

import os, shutil

try:
   shutil.rmtree(path)
   print('folder removed')
except Exception as e:
   print('folder not removed')
   print(e)

answered Oct 21 '19 at 14:16

Fabio Caccamo

1,871
19
21

Check in python if deleting folder was successful and if yes, continue

3 Answers3