Object has type qualifiers that are not compatible, possible inheritance/polymorphism mistake?

Question

class Node
{
protected:
    int decimal_value;
    char letter;
public:
    Node(int decimal, char lett) : decimal_value(decimal), letter(lett)
    {}
    Node() :decimal_value(0), letter(NULL)
    {}
     int get_decimal()
    {
        return decimal_value;
    }
    char get_letter()
    {
        return letter;
    }
    void set_decimal(int n)
    {
        decimal_value = n;
    }
    void set_letter(char l)
    {
        letter = l;
    }
    friend bool operator<( Node& p1, Node& p2)
    {
        return p1.decimal_value > p2.decimal_value;
    }
    virtual ~Node() {};
};
class Leaf :public Node
{
    using Node::Node;

};
class Branch :public Node
{

    Node* left;
    Node* right;
public:

    Branch(Node* l, Node* r) :left(l), right(r)
    {
        decimal_value = l->get_decimal() + r->get_decimal();

    }

};
void tree_builder(priority_queue<Node> Q)
{
    Node* qleft=new Leaf;
    Node* qright= new Leaf;
    while (Q.size() > 1)
    {
        *qleft = Q.top();
        Q.pop();
        *qright = Q.top();
        Q.pop();
        Branch* b1 = new Branch(qleft, qright);
        Q.push(*b1);

        cout << Q.top().get_decimal();
    }




}

Branch and Leaf are both children of Node, however on the very last line when I try to cout the top of my queue. The "q.top()" is giving me the error "the object has type qualifiers that are not compatible with member function get_decimal" and I'm not sure why. I have included Node branch and Leaf classes.

On a side note, `tree_builder()` should take the `priority_queue` by reference not by value. And it is leaking the objects it `new`s. And `Q.push(*b1)` [slices the `Branch` object](https://stackoverflow.com/questions/274626/). Since you are trying to store polymorphic classes in the queue, you need to use `Node*` pointers in your queue, not `Node` objects. — Remy Lebeau, Oct 23 '19 at 20:26

score 1 · Accepted Answer · answered Oct 23 '19 at 20:19

priority_queue::top() returns a reference to a const object (const T &), but get_decimal() is not declared with the const qualifier so it cannot be called on a const object. You need to add the const qualifier:

int get_decimal() const // <-- HERE
{
    return decimal_value;
}

You should do the same for your get_letter() getter, too:

char get_letter() const
{
    return letter;
}

You should also change your operator< to take const Node & references as well:

friend bool operator<(const Node& p1, const Node& p2)
{
    return p1.decimal_value > p2.decimal_value;
}

Object has type qualifiers that are not compatible, possible inheritance/polymorphism mistake?

1 Answers1