Declaring an Array from a Class in C#

Question

I want to create an Array of "Highscore" objects that I defined with a class.
I'm always getting a NullReferenceException when I try to set or read the Value of a specific Array content.

It does work when I use a single Highscore object instead of an Array.

It also does work when I use an integer array instead of an Highscore Array.

Code

class Highscore
{
    public int score;
}
class Program
{
    static void Main()
    {
        Highscore[] highscoresArray = new Highscore[10];
        highscoresArray[0].score = 12;
        Console.WriteLine(highscoresArray[0].score);
        Console.ReadLine();
    }
}

System.NullReferenceException:

highscoresArray[] was null.

`Highscore[] highscoresArray = Enumerable.Range(0, 10).Select(x => new Highscore()).ToArray();` — Dmitry Bychenko, Nov 06 '19 at 11:16
check this one https://stackoverflow.com/questions/5678216/all-possible-array-initialization-syntaxes — Jayakumar Thangavel, Nov 06 '19 at 11:18

score 7 · Accepted Answer · edited Nov 06 '19 at 11:16

7

in this code:

Highscore[] highscoresArray = new Highscore[10];

you instantiate an array of Highscore objects but you do not instantiate each object in the array.

you need to then do

for(int i = 0; i < highscoresArray.Length; i++)
    highscoresArray[i]  = new Highscore();

edited Nov 06 '19 at 11:16

Dmitry Bychenko

180,369
20
160
215

answered Nov 06 '19 at 11:08

Tim Rutter

4,549
3
23
47

score 1 · Answer 2 · answered Nov 06 '19 at 11:08

1

You have to add a Highscore to the array first, for example:

highscoresArray[0] = new Highscore();

answered Nov 06 '19 at 11:08

Marce

467
1
6
10

score 1 · Answer 3 · answered Nov 06 '19 at 11:09

1

That's because you've created an array, set its length, but never actually instantiated any of its elements. One way to do so would be:

Highscore[] highscoresArray = new Highscore[10];
highscoresArray[0] = new Highscore();

answered Nov 06 '19 at 11:09

Aly Elhaddad

1,913
1
15
31

score 0 · Answer 4 · answered Nov 06 '19 at 11:08

0

Maybe you need to initialize every item of the array:

 for (int i = 0; i < highscoresArray.length; i++)
 {
      highscoresArray[i] = new Highscore();
 }

answered Nov 06 '19 at 11:08

CR0N0S.LXIII

349
2
11

score 0 · Answer 5 · answered Nov 06 '19 at 12:32

0

.. Or use a Struct

struct Highscore
{
    public int score;
}

answered Nov 06 '19 at 12:32

Dmitriy Gavrilenko

300
1
3
18

What are the dis/advantages of a struct? – Joshua Drake Nov 06 '19 at 15:12
@JoshuaDrake Specifically in this case - no initialization required. – Dmitriy Gavrilenko Nov 13 '19 at 14:18
The comment came from the review queue, we prefer answers to include the why, and not just the code. – Joshua Drake Nov 16 '19 at 14:43

Declaring an Array from a Class in C#

5 Answers5