UNO game in java early stages issue

Question

As part of my assignment this week (computer programming I), I am supposed to work on the UNO game that we are working on throughout the class. The game will be played between ONLY computers, so no keyboard input except for the occasional enter to make the game continue (kinda boring right?). This week we are supposed to make some classes for each part of the game (such as the CARD class and the HAND class). I was able to do this, but the second part of my assignment--to have a driver program that: " creates a deck of UNO cards, deals the cards to two or more players, and displays the contents of each player’s hand."-- has me stuck. I've tried multiple printing methods that I know with my incredibly limited skills, but I've come up with nothing. Any Ideas?

Here's the Code:

public class CARD
{
    public String color;
    public int value;
    private Random random;
    private String face;

    public CARD(int v, String c)
    {
        value = v;
        color = c; 
    }

public CARD()
{
    random = new Random();
    value = random.nextInt(28); // 108 cards in a deck and it Can be reduced to 27 which ignores colors
    // Assigns value
    if (value >= 14) // Some cards show up more often (numbers)
        value -= 14;
    // Assigns color
    random = new Random();
    switch(random.nextInt(4) ) //learned about switches here: https://www.youtube.com/watch?v=RVRPmeccFT0
    {
        case 0: color = "Red"; 
            break;
        case 1: color = "Green"; 
            break;
        case 2: color = "Blue"; 
            break;
        case 3: color = "Yellow"; 
            break;
    }
    // If the card is wild 
    if (value >= 13)
        color = "none";
    }
}

Somehow, it seems a bit overkill for each `CARD` to create its own `new Random()`. — Solomon Slow, Nov 11 '19 at 01:59
Also note, there is nothing random about an UNO deck. The deck always contains the same exact set of cards. The radomness in a game of UNO enters when you _shuffle_ the cards (i.e., when you take the fixed set of cards and you arrange them in some randomly chosen order.) — Solomon Slow, Nov 11 '19 at 02:01

FailingCoder · Answer 1 · 2019-11-11T01:49:05.557

0

Based on the code you've provided, I would recommend using a for loop to make cards:

public class DriverProgram {
    static final int players = 2, numberOfCards = 7;
    public static void main (String[] args){
         java.util.ArrayList<CARD> c = new java.util.ArrayList<CARD>();
         for(int i=0; i<numberOfCards; i++){
             c.add(new CARD()); // The previous example used a fixed size array
         } // Arrays.fill() would make all the cards identical
         System.out.println(c); 
         // Note: ArrayLists print themselves nicely with their toString method.
         // If you'd like, you could do String.replace("[", "").replace... to remove
         // certain characters.
    }
}

How do I print my Java object without getting "SomeType@2f92e0f4"?

edited Nov 11 '19 at 01:49

answered Nov 11 '19 at 00:21

FailingCoder

757
1
8
20

You need to create cards to use them. – FailingCoder Nov 11 '19 at 00:41
What kind of loop should I use? Sorry, I'm really new to this. – Zach Goniea Nov 11 '19 at 00:42
I thought my code made the cards, what do I need to add? – Zach Goniea Nov 11 '19 at 00:43
That is a card class. It doesn't actually make the cards; it just describes what exactly a card is. You really don't have to add anything to your card class, but I would recommend a toString method override. – FailingCoder Nov 11 '19 at 00:47
You don't need any loop now that I've realized how you can simply print it. Also, you can use a `while(!c.isEmpty()) System.out.println(c.remove(0))` – FailingCoder Nov 11 '19 at 00:50
I've got this (obviously better formatted): @Override public String toString() return card; But I think I have the variables wrong, what needs to change? – Zach Goniea Nov 11 '19 at 00:58
You have to return a String variable for the toString method. – FailingCoder Nov 11 '19 at 00:59
One last thing, That code you sent me is outputting an error. Do I need to edit some variables and where should I place it in my program? – Zach Goniea Nov 11 '19 at 01:02
Multiple markers at this line - c cannot be resolved - c cannot be resolved – Zach Goniea Nov 11 '19 at 01:08
I copied the code into my own compiler and it did not show any errors. Are you sure you copied the exact code? – FailingCoder Nov 11 '19 at 01:10
Simply try copying it again? Maybe you cropped out the initialization of the arraylist? – FailingCoder Nov 11 '19 at 01:26
To be clear, the code that is having an error is: while(!c.isEmpty()) System.out.println(c.remove(0)) – Zach Goniea Nov 11 '19 at 01:30

UNO game in java early stages issue

1 Answers1