Serializer field for integer or string

Question

I want to have serializer with field which can take integer(not floats or any other numeric type!) or string as an input.Is there any way to make it better/more pretty?

class MyField(Field):
    def to_representation(self, value):
        if isinstance(value, int):
            return value
        elif isinstance(value, str):
            return value
        else:
            raise ValidationError('Error')

    def to_internal_value(self, data):
        if isinstance(data, int):
            return data
        elif isinstance(data, str):
            return data
        else:
            raise ValidationError('Error')

class MySerializer(Serializer):
    my_field = MyField()

What if value is `'1.0'` (a string), do you accept it as well or not? — Arn, Nov 18 '19 at 17:02

Arn · Accepted Answer · 2019-11-19T12:23:04.597

You may combine the conditions as below:

class MyField(Field):
    def to_representation(self, value):
        if isinstance(value, int):
            return value
        elif isinstance(value, str) and value.isdigit():
            return value
        raise ValidationError('Error')

    def to_internal_value(self, data):
        if isinstance(data, int):
            return data
        elif isinstance(data, str) and data.isdigit():
            return data
        raise ValidationError('Error')

class MySerializer(Serializer):
    my_field = MyField()

Serializer field for integer or string

1 Answers1