Trapping a Variable in a Range

Asked Nov 19 '19 at 08:32

Active Nov 19 '19 at 08:32

Viewed 151 times

I want to keep a variable in the range of [min, max]. For this purpose, I wrote this function:

void trapVar(int& var, int& min, int& max) {
   if(var < min) var = min;
   else if(var > max) var = max;
}

Is there any efficient or better (or any other implementation) way to realize this function? Maybe this implementation is the simplest one? You can comment on the coding style also.

asked Nov 19 '19 at 08:32

Erdem Tuna

11

The standard library provides: `std::clamp` – Mansoor Nov 19 '19 at 08:33
2

Like Mansoor said. Here is the link to cppreference: https://en.cppreference.com/w/cpp/algorithm/clamp – eike Nov 19 '19 at 08:35
5

There is no point in passing `min` and `max` as references. You also probably want to verify that `min <= max`. – molbdnilo Nov 19 '19 at 08:37
7

Only problem with `std::clamp()` is it's C++17 and the question is tagged C++11. – Shawn Nov 19 '19 at 08:42
2

Possibly relevant: [Limiting range of value types in C++](https://stackoverflow.com/q/148511/580083). – Daniel Langr Nov 19 '19 at 08:51
4

You can use implementation of the `std::clamp()` from cppreference to your code :) – Raffallo Nov 19 '19 at 08:51
Thank you everyone for the comments. As you all suggested, I will look at the implementation of std::clamp(). – Erdem Tuna Nov 19 '19 at 16:14
And I guess `to clamp` is the right vocabulary instead of `to trap` :) – Erdem Tuna Nov 19 '19 at 16:16
1

good practice is to have ```const``` references for your read only ```min``` and ```max``` – hazirovich Nov 20 '19 at 07:49

Trapping a Variable in a Range

0 Answers0