Axios inside for loop

Question

I am trying to axios requests inside a for loop but the loop is being completed even before the axios. Following is my code:

let findEmail = async() => {
 for (var i = 0; i < csvData.length; i++){
    axios.post('https://email-finder.herokuapp.com/find', {
        "first_name": "Irinaa",
        "last_name": "xyz",
        "domain": "xyxz.com"
    }).then((response) => {
        if(response.status === 500){
            console.log('no email found');
        }
        else{
            console.log(response.data);
        }
    }, (error) => {
        console.log('no email found ', i);
    });
      console.log('axios request done');
 }
}

I want the loop to wait until the request is complete and then go to increment the i variable. Any help would be much appreciated. Thank you

try to use promises while if you are good with observables that can help you too — sainanky, Dec 05 '19 at 07:25

Anubhav Gupta · Accepted Answer · 2019-12-05T07:23:01.093

2

As you are in async function try using await instead of then. It will make your for loop behave synchronously.

let findEmail = async () => {
      for (var i = 0; i < csvData.length; i++) {
        try {
          let response = await axios.post(
            "https://email-finder.herokuapp.com/find",
            {
              first_name: "Irinaa",
              last_name: "xyz",
              domain: "xyxz.com"
            }
          );
          if (response.status === 500) {
            console.log("no email found");
          } else {
            console.log(response.data);
          }
        } catch (error) {
          console.log("no email found ", i);
        }
        console.log("axios request done");
      }
    };

edited Dec 05 '19 at 07:23

answered Dec 05 '19 at 07:19

Anubhav Gupta

66
4

There is a major difference between making something synchronous and behaving synchronously. – Shubham Dixit Dec 05 '19 at 07:21
1

Great Catch. It was my first answer, so you can say noob spotted. – Anubhav Gupta Dec 05 '19 at 07:25

score 0 · Answer 2 · answered Dec 05 '19 at 07:20

0

Please find the explanation on How to await an async call in JavaScript in a synchronous function? here by T.J. Crowder.

answered Dec 05 '19 at 07:20

Selaka Nanayakkara

3,296
1
22
42

score 0 · Answer 3 · answered Dec 05 '19 at 07:22

0

If you are waiting to get data back, so you are waiting to status 200. Try to add:

    else if(response.status === 200){
        console.log(response.data);
    }

answered Dec 05 '19 at 07:22

Ziv Ben-Or

1,149
6
15

score 0 · Answer 4 · answered Sep 21 '21 at 13:48

Another pattern to consider: use an array of promises and Promise.all.

For example:

let findEmail = async() => {
 const promises = []
 for (var i = 0; i < csvData.length; i++){
    const request = axios.post('https://email-finder.herokuapp.com/find', {
        "first_name": "Irinaa",
        "last_name": "xyz",
        "domain": "xyxz.com"
    }).then((response) => {
        if(response.status === 500){
            console.log('no email found');
        }
        else {
            console.log(response.data);
        }
    }, (error) => {
        console.log('no email found ', i);
    });
      console.log('axios request done');
      promises.push(request)
 }
await Promise.all(promises)
}

Axios inside for loop

4 Answers4

Linked

Related