Check whether the time lies between 2 times

Question

The application must display the message whether the gate is open or closed depending on the current time of the day.

The gate opens between 8:00am and before 9:30am OR after 5:50pm and before 9:00pm while the rest of the time the gate remains closed. I want to display the message based on the time input. The below code output is unexpected and incorrect.

function isValid(date, h1, m1, h2, m2) {
        var h = date.getHours();
        var m = date.getMinutes();
        return (h1 < h || h1 == h && m1 <= m) && (h < h2 || h == h2 && m <= m2);
    }


function a() {
        var current = new Date('2020-01-03 09:31:00');
        if ((isValid(current, 8, 0, 9, 30)) || (isValid(current, 5, 50, 21, 0))) {
            return 'Gate is open'
        } else {
            return 'Please come after 8:00am and before 9:30am OR after 5:50pm and before 9:00pm';
        }
}a();

Does this answer your question? [compare timestamps in javascript](https://stackoverflow.com/questions/46478974/compare-timestamps-in-javascript) — Dan O, Jan 03 '20 at 14:12
No. What I expect is to display Gate is open or the else message depending on the input time. The input time here is 2020-01-03 09:31:00 which must display "Please come after..." — user3436029, Jan 03 '20 at 14:43
that link shows you exactly how to compare the current time against some other arbitrary time, which is exactly what you asked. — Dan O, Jan 03 '20 at 20:48
Parsing of unsupported string formats is implementation dependent. `new Date('2020-01-03 09:31:00')` returns an invalid date in at least one current browser, see [*Why does Date.parse give incorrect results?*](https://stackoverflow.com/questions/2587345/why-does-date-parse-give-incorrect-results) — RobG, Jan 04 '20 at 04:11

ssten · Accepted Answer · 2020-01-03T14:54:18.503

2

You've have to use 17 instead of 5 in the pm date

function isValid(date, h1, m1, h2, m2) {
  var h = date.getHours();
  var m = date.getMinutes();
  return (h1 <= h && m1 <= m) && (h <= h2 && m <= m2);
}


function a() {
  var current = new Date('2020-01-03 09:31:00');
  if ((isValid(current, 8, 0, 9, 30)) || (isValid(current, 17, 50, 21, 0))){
    return 'Gate is open'
  } else {
    return 'Please come after 8:00am and before 9:30am OR after 5:50pm and before 9:00pm';
  }
}

edited Jan 03 '20 at 14:54

answered Jan 03 '20 at 14:19

ssten

1,848
1
16
28

How do I make a time comparison? What I expect is to display Gate is open or the else message depending on the input time. The input time here is 2020-01-03 09:31:00 which must display "Please come after..." – user3436029 Jan 03 '20 at 14:44

A Ralkov · Answer 2 · 2020-01-03T14:19:26.223

0

You can use simply Date object as int:

function isValid(date, h1, m1, h2, m2) {
        var h = date.getHours();
        var m = date.getMinutes();

        var d1 = new Date(date);
        d1.setHours(h1);
        d1.setMinutes(m1);

        var d2 = new Date(date);
        d2.setHours(h2);
        d2.setMinutes(m2);

        return (date-d1)*(date-d2) < 0;
    }

edited Jan 03 '20 at 14:19

answered Jan 03 '20 at 14:12

A Ralkov

1,046
10
19

No. What I expect is to display Gate is open or the else message depending on the input time. The input time here is 2020-01-03 09:31:00 which must display "Please come after..." – user3436029 Jan 03 '20 at 14:44
You can set the hours and minutes in one go: `d1.setHours(h1, m1)`. ;-) – RobG Jan 04 '20 at 04:12

Check whether the time lies between 2 times

2 Answers2