jQuery button to check all check boxes issue

Question

I have a button that checks all checkboxes in a div and un-checks.

However if I were to manually check one checkbox, then hit the Check all button and then uncheck all, the checkbox which was manually checked does not become unchecked!

Any ideas?

http://jsfiddle.net/hM5bu/1/

score 6 · Accepted Answer · edited May 23 '17 at 12:34

6

Thats because jQuery was changed in 1.6

Using attr instead of prop is what is breaking it.

Try using prop instead

Updated fiddle: http://jsfiddle.net/hM5bu/2/

See this question: .prop() vs .attr() for more about prop and attr in jQuery 1.6

edited May 23 '17 at 12:34

Community

1
1

answered May 11 '11 at 16:05

Naftali

144,921
39
244
303

@AJFMEDIA remember to select an `accepted answer` when you can ^_^ – Naftali May 11 '11 at 16:09
Yikes. This makes moving to 1.6 a big deal. – Jeff Davis May 11 '11 at 16:10
@Jeff, they fixed the problem in [jQuery 1.6.1](http://itknowledgehub.com/development-integration/jquery-1-6-1-rc-1-released/) – Naftali May 11 '11 at 16:10
@Jeff, just make sure to get 1.6.1 and **not** 1.6 – Naftali May 11 '11 at 16:13
@jeff this is the official 1.6.1 link: http://blog.jquery.com/2011/05/10/jquery-1-6-1-rc-1-released/ – Naftali May 11 '11 at 16:29

score -1 · Answer 2 · answered May 11 '11 at 17:21

here is a solution:

<input type="checkbox" name="todos" id="todos" /> All<br/>
<input class="marcartodos" type="checkbox" name="marcado[]" value="1" />1<br/>
<input class="marcartodos" type="checkbox" name="marcado[]" value="2" />2<br/>
<input class="marcartodos" type="checkbox" name="marcado[]" value="3" />3<br/>
<input class="marcartodos" type="checkbox" name="marcado[]" value="4" />4<br/>

<script type="text/javascript">

$(function() {

$("#todos").click(function() {                          
if ($(this).is(':checked'))                         
$(".marcartodos").attr('checked', true);
else 
$(".marcartodos").attr('checked', false);
});

});

</script>

that **DOES NOT** solve it at all! it has the same problem: http://jsfiddle.net/hM5bu/3/ — Naftali, May 11 '11 at 17:23
Yes, you are right, @Neal. The attr() method doesn't work on jQuery 1.6. Sorry. — Regis, May 12 '11 at 13:55

jQuery button to check all check boxes issue

2 Answers2