14

I'm trying to reuse a fragment in different navigation graphs with safe args enabled. I noticed that if the actions are different I get a compilation error. This is because the xxxFragmentDirections autogenerated code will only generate one of the actions.

In nav_graph_1.xml:

<navigation 
  ...
  <fragment
    android:id="@+id/myFragment"
    android:name="com.example.android.MyFragment">
    <action
      android:id="@+id/next_action"
      app:destination="@+id/dest_one" />
  </fragment>
  ...

In nav_graph_2.xml:

<navigation 
  ...
  <fragment
    android:id="@+id/myFragment"
    android:name="com.example.android.MyFragment">
    <action
      android:id="@+id/other_action"
      app:destination="@+id/other_dest" />
  </fragment>
  ...

A simple use case: A bank app that has two flows: withdraw and deposit, therefore you could have two nav graphs. You could have an AmountFragment where you could just enter a number and this could be reused to either withdraw or deposit. However, depending on the flow, the actions/destinations could be different.

Then, how would it be possible to reuse this fragment?

fernandospr
  • 2,976
  • 2
  • 22
  • 43
  • Why, inheritance of course. Is there a better way? Probably not with safeargs. – EpicPandaForce Jan 14 '20 at 10:51
  • Do you mean having a `BaseAmountFragment`, `WithdrawAmountFragment` and a `DepositAmountFragment`? – fernandospr Jan 14 '20 at 13:45
  • 1
    Yes, although I also feel that design-wise, it's a terrible idea long-term. – EpicPandaForce Jan 14 '20 at 14:37
  • You can take a look at the auto-generated code and create a class on your own. Like `class CustomDirections private constructor() { private data class ActionFromFragmentToFragment( val arg: Arg? = null ) : NavDirections { override fun getActionId(): Int = R.id.action_id override fun getArguments(): Bundle {…} } companion object { fun actionFromFragmentToFragment(arg: Arg? = null): NavDirections = ActionFromFragmentToFragment(arg) } }` – Jorge Gonzales Oct 24 '20 at 15:59

3 Answers3

7

Use navigate() with bundle instead of actions in edge cases. Don’t call 

findNavController().navigate(FragmentDirections.goToDetailFragment(id))

but instead use 

findNavController().navigate(R.id.DetailFragment, bundleOf("id" to 5))

This way you don’t rely on the generated direction but can still use the Navigation and SafeArgs features of the DetailFragment.

https://code.allaboutapps.at/articles/android-jetpack-navigation-pitfalls/#reuse-fragments-in-multiple-navigation-graphs

dabo248
  • 3,367
  • 4
  • 27
  • 37
  • Great answer. I was learning about nav components. And in the sample project, I was reusing a fragment for different input based on enums in the argument bundle. When using SafeArgs for a nested flow, I kept getting unresolved references on some actions. Tried your approach without safeArgs, problem solved, thanks. – Haomin Feb 24 '22 at 21:57
  • But same fragment multiple time added how to remove it? – GvHarish Jun 11 '22 at 17:07
3

This can be achieved by providing the same action ID in both the navigation graph.

In nav_graph_1.xml:

<navigation 
  ...
  <fragment
    android:id="@+id/myFragment"
    android:name="com.example.android.MyFragment">
    <action
      android:id="@+id/next_action"
      app:destination="@+id/dest_one" />
  </fragment>
  ...

In nav_graph_2.xml:

<navigation 
  ...
  <fragment
    android:id="@+id/myFragment"
    android:name="com.example.android.MyFragment">
    <action
      android:id="@+id/next_action"
      app:destination="@+id/other_dest" />
  </fragment>
  ...

In fragment, navigation can be performed like

NavHostFragment.findNavController(<myFragment>).navigate(R.id.next);

Nilesh Tiwari
  • 194
  • 2
  • 7
-1

It might not be what you ask, but I faced the problem o re-usability of code in a fragment that I needed in different navigation graphs.

The fragment class that needs to be reused should be declared as abstract:

abstract class ReusableFragment(val type: ReusableEnum): Fragment(){
    enum class ReusableEnum{Type1, Type2}
    // the rest of your logic will use 
    // 'type' variable in when() blocks to determine 
    // specific logic for each case
}

class Type1Fragment: ReusableFragment(ReusableEnum.Type1)
class Type2Fragment: ReusableFragment(ReusableEnum.Type2)

This way, Type1Fragment and Type2Fragment are available in NavigationGraph as independent fragments.

RonaldPaguay
  • 337
  • 3
  • 12