Trying to take input in Switch case of Java, but showing me another result. What is the specific problem here?

Question

import java.util.Scanner;
public class Dx {

    public static void main(String[] args) {
        Scanner myObj = new Scanner(System.in);
        String day = myObj.nextLine();
        if (day == "morning") {
            System.out.println("Good Morning");
        } else if (day == "afternoon") {
            System.out.println("Good Afternoon");
        } else if (day == "evening") {
            System.out.println("Good evening!");
        } else if (day == "night") {
            System.out.println("Good night");
        } else {
            System.out.println("Good Day");
        }
    }
}

Here the output shows Good Day when giving night or morning.

Does this answer your question? [How do I compare strings in Java?](https://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java) — Michael Bianconi, Jan 20 '20 at 17:56
Also, you are using an `if-else` cascade, not `switch-case`. — Turing85, Jan 20 '20 at 17:58

score 0 · Accepted Answer · answered Jan 20 '20 at 19:28

0

As was mentioned in the comments above:

    Scanner myObj = new Scanner(System.in);
    String day = myObj.nextLine();
    switch(day) {
        case "morning" :
            System.out.println("Good Morning"); break;
        case "afternoon":
            System.out.println("Good Afternoon"); break;
        case "evening":
            System.out.println("Good evening!"); break;
        case "night" :
            System.out.println("Good night"); break;
        default:
            System.out.println("Good Day");
    }

answered Jan 20 '20 at 19:28

Rex

46
2

Good suggestion. But you should have address the issue of OP first – Suresh Atta Jan 21 '20 at 09:56
What is OP? This is a solution to the problem presented, is it not? – Rex Jan 21 '20 at 15:11

score -1 · Answer 2 · edited Jan 20 '20 at 18:02

-1

Strings in java are best compared by the .equals() method.

if (stringA.equals(stringB)) {
    ...
}

edited Jan 20 '20 at 18:02

Turing85

18,217
7
33
58

answered Jan 20 '20 at 17:59

pikkuez

310
1
18

Please, don't answer questions that are clearly duplicate :) – Federico klez Culloca Jan 20 '20 at 17:59

Trying to take input in Switch case of Java, but showing me another result. What is the specific problem here?

2 Answers2