MongoDb delete documents by passing user id

Question

I am new to node and mongo db. I have a list of users with delete link in each row.I am trying to delete a user with its _id. However its not working. Here is my router code.

router.get('/delete/:id', function (req,res) {
    const ObjectId = require('mongodb').ObjectID;
    var id = req.params.id;
    console.log(id);
    db.collection('users').deleteOne({ _id: ObjectId(req.params.id) }, function(err, res) {
        if (err) {
        throw err;
        } else {
          return res.redirect('/'); 
        }
      });

  });

Here is my view, on clicking this link I am getting the _id in my url as this : http://localhost:3000/delete/4428439e14e3343ba4ac31c1

<td><a href="/delete/ <%=  userdetails._id %>">Delete</a></td>

console.log(id) gives me 4428439e14e3343ba4ac31c1

But it throws me the below error

Error: Argument passed in must be a single String of 12 bytes or a string of 24 hex characters at new ObjectID

I've been update my answer, maybe it's will be work and don't forget to read my reply comment. — Titus Sutio Fanpula, Jan 27 '20 at 08:36

score 1 · Answer 1 · answered Jan 27 '20 at 07:18

1

You need to create a instance of ObjectId using new. Currently, you are passing the ObjectId directly so you are getting that error.

db.collection('users').deleteOne({_id: new ObjectId(req.params.id)},  function(err, res) {
  if (err) {
    throw err;
  } else {
    return res.redirect('/');
  }
});

answered Jan 27 '20 at 07:18

Ankit Agarwal

30,378
5
37
62

@Oops try with `{_id: req.params.id}` – Ankit Agarwal Jan 27 '20 at 07:21
this one removed the error, but is not deleting the record from database. – Oops Jan 27 '20 at 07:28
Thank you for the code.Issue was with the extra space in my href link – Oops Jan 27 '20 at 08:55

Sarfraaz · Accepted Answer · 2020-01-27T08:49:02.773

1

Try this, you don't need to create ObjectID if the string is a valid ObjectID

For prevention, you can use a function like below to test if valid ObjectID is passed or not

function validateObjectId (id) {
    if (ObjectId.isValid(id)) {
        const obj = new ObjectId(id);
        if (obj == id) {
            return true;
        }
    }
    return false;
},


if(!validateObjectId(req.params.id))
    return res.send({'error':'Invalid ObjectID Passed',id:req.params.id});

db.collection('users').deleteOne({ _id: ObjectId(req.params.id) }, function(err, res) 
{
    if (err) {
    throw err;
    } else {
      return res.redirect('/'); 
    }
  });

Also remove extra space from here

<td><a href="/delete/<%=userdetails._id%>">Delete</a></td>

edited Jan 27 '20 at 08:49

answered Jan 27 '20 at 07:28

Sarfraaz

1,273
4
15

it shows Invalid ObjectID Passed. How can I resolve this. – Oops Jan 27 '20 at 07:57
Use my updated function above & share the exact response you get – Sarfraaz Jan 27 '20 at 08:19
I tested it for another user and got the following response error "Invalid ObjectID Passed" id " 5e2e9c65277a6f2d4881f70f" – Oops Jan 27 '20 at 08:31

Titus Sutio Fanpula · Answer 3 · 2020-01-27T08:33:53.620

1

Maybe you can try this code below:

router.get("/delete/:id", function(req, res) {
  const ObjectId = require("mongodb").ObjectId;
  var { id } = req.params;
  console.log(id);
  db.collection("users").findOneAndDelete({ _id: ObjectId(id) }, function(
    error,
    response
  ) {
    if (error) {
      throw err;
    } else {
      return res.redirect("/");
    }
  });
});

Updated:

Try looking at your code. There's confusing code, you use 2 times res. One is res from express and the other isres when it succeeds in removing at mongodb.

So, the res.redirect ('/') that you use in your mongodb function is res from mongodb, notres from express.

Try replacing {err, res} with {error, response}.

I hope it can help you.

edited Jan 27 '20 at 08:33

answered Jan 27 '20 at 07:32

Titus Sutio Fanpula

3,467
4
14
33

1

Same error : Argument passed in must be a single String of 12 bytes or a string of 24 hex characters – Oops Jan 27 '20 at 07:57
I've been try that code above and it's working fine. Have you copied my code and tried it? – Titus Sutio Fanpula Jan 27 '20 at 07:58
I've been try at my self and how to fix it is try to comment out your code that you think is wrong, after that save and reload your page. If you don't get an error, please open the comment and everything will return to normal. That's what I just did. – Titus Sutio Fanpula Jan 27 '20 at 08:14
Thank you for the code.Issue was with the extra space in my href link. – Oops Jan 27 '20 at 08:54

Prakash Karena · Answer 4 · 2020-01-27T08:20:17.643

1

you can use findByIdAndRemove

router.get('/delete/:id', function (req,res) {
    var id  = req.params.id;
    db.collection('users').findByIdAndRemove( id , function(err, res) {
        if (err) {
        throw err;
        } else {
          return res.redirect('/'); 
        }
      });

  });

edited Jan 27 '20 at 08:20

answered Jan 27 '20 at 07:53

Prakash Karena

2,525
1
7
16

this one gives me Error: Argument passed in must be a single String of 12 bytes or a string of 24 hex characters – Oops Jan 27 '20 at 07:59
try this out and let me know if still you get any error – Prakash Karena Jan 27 '20 at 08:21
It gives me : TypeError: db.collection(...).findByIdAndRemove is not a function – Oops Jan 27 '20 at 08:25
Thank you for the code.Issue was with the extra space in my href link – Oops Jan 27 '20 at 08:55

MongoDb delete documents by passing user id

4 Answers4

Linked