Cannot resolve ViewModelProvider construction in a fragment?

Question

I have been spending a lot of time trying to figure out why in the code below (towards the end), I get an error on ViewModelProvider(this). I also tried getActivity() instead of 'this', same issue. The error I get is "Cannot resolve constructor ..."


import androidx.fragment.app.Fragment;
import androidx.lifecycle.ViewModelProvider;



public class ItemSetupFragment extends Fragment {

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragment_setup, container, false);

        return view;
    }

    @Override
    public void onViewCreated(@NonNull View view, Bundle savedInstanceState) {
        super.onViewCreated(view, savedInstanceState);

        ItemSetupFragmentModel model = new ViewModelProvider(this).get(ItemSetupFragmentModel.class);
        model.getKids().observe(this, users -> {
            // update UI
        });
    }
}

Updated answer. You should use the latest version of viewmodel. — Shababb Karim, Feb 05 '20 at 07:14

score 46 · Accepted Answer · edited Jun 10 '20 at 03:50

46

Firstly you need to use the latest version of lifecycle extension. It should be:

implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
implementation "androidx.lifecycle:lifecycle-viewmodel:2.2.0"

or any updated version.

Then you should use requireActivity() instead of getActivity(). This way you will ensure that the activity is attached an not getting a NullPointerException.

ItemSetupFragmentModel model = new ViewModelProvider(requireActivity()).get(ItemSetupFragmentModel.class);

Note: ViewModel Overview and Declaring Dependencies

I had to restart cache after adding the library to the Gradle file. There is no need to use requireActivity(), this is enough.

edited Jun 10 '20 at 03:50

FDLC

90
2
2
9

answered Feb 05 '20 at 07:02

Shababb Karim

3,614
1
22
35

Thank you. That was it. I had to added those lines to my Gradle. – LeaningAndroid Feb 05 '20 at 07:21
I am having the same code working in one Fragment and Failing in another fragment. – nyxee Jul 03 '20 at 09:19
Is it for the same problem? Make sure you're using the same fragment class from the same package or something. – Shababb Karim Jul 03 '20 at 21:00

score 7 · Answer 2 · answered Feb 05 '20 at 07:18

You aren't using the latest library release in which the ViewModelProvider(@NonNull ViewModelStoreOwner owner) constructor was included. You are seeing the latest docs but not using the latest library version of ViewModel. You need to use

    implementation 'androidx.lifecycle:lifecycle-viewmodel:2.2.0' // For Java

or

    implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0' // For kotlin extension

score 2 · Answer 3 · answered Feb 05 '20 at 07:34

The cleanest implementation must use Kotlin for its advanced functions. You can either create this kotlin code in a separate Kclass or leave this answer for future users that want to know how to do this in Kotlin. Basically we are initialising the ViewModel by lazy like this:

Make sure you have this dependency:

implementation "androidx.fragment:fragment-ktx:1.2.0"

Create this helper function that accesses an internal fragment-ktx method that allows yo to create a ViewModel instance by lazy:

@MainThread
inline fun <reified VM : ViewModel> Fragment.fragmentViewModel() =
    createViewModelLazy(
        VM::class,
        { this.viewModelStore },
        { ViewModelFactory(Database.getDatabase(requireContext().applicationContext)) }
    )

Now create a ViewModelFactory using this official java example:

https://github.com/android/architecture-components-samples/blob/master/BasicRxJavaSample/app/src/main/java/com/example/android/observability/ui/ViewModelFactory.java

Or, here is the Kotlin variant:

class ViewModelFactory(private val database: Database?) : ViewModelProvider.Factory {

    override fun <T : ViewModel> create(modelClass: Class<T>): T {

        requireNotNull(database) { "Database must not be null" }

        return when {

            modelClass.isAssignableFrom(ItemSetupFragmentModel::class.java) -> {
                ItemSetupFragmentModel() as T
            }

            else -> {
                throw IllegalArgumentException("Unknown ViewModel class")
            }
        }
    }
}

And now go inside your fragment and simply initialise your ViewModel like this

class ItemSetupFragment : Fragment() {

    private val model by viewModel<ItemSetupFragmentModel>()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)

        model.getKids().observe(this, users -> {
            // update UI
        });
    }
}

Hope this helps!

score 0 · Answer 4 · edited Feb 05 '20 at 07:04

0

You should instantiate your viewModel by :

ItemSetupFragmentModel model = ViewModelProviders.of(this).get(ItemSetupFragmentModel.class);

edited Feb 05 '20 at 07:04

Somesh Kumar

8,088
4
33
49

answered Feb 05 '20 at 06:47

Bheem

189
2
9

3

@Bheen, ViewModelPorviders is deprecated. The doc say to use the constructors for ViewModelProvider directly. – LeaningAndroid Feb 05 '20 at 06:52

Cannot resolve ViewModelProvider construction in a fragment?

4 Answers4

Linked