Bash loop thru file takes only first line

Question

Hi I have this script to debloat my phone:

#!/bin/bash

adb devices
sleep 1

cat packagelist.txt | while read line 
do  
    echo removing $line
    adb shell pm uninstall --user 0 $line 
done

and packagelist.txt is something like

com.miui.miwallpaper
com.miui.cloudservice
com.miui.notes

with the new line at the end. If I comment the line with adb shell etc.. it kindly prints all the lines of the file as should be but otherwise it only excecutes the command with the first package and then exits. The first package is already uninstalled so it gives an error but I'd like to ignore them and continue the loop. I tried also without the loop hardcoding the package name in adb shell etc... and this continues even if the first gives an error.

score -1 · Answer 1 · answered Feb 05 '20 at 12:02

-1

Can you try this?

I have the feeling the while loop is not able to consume stdin correctly.

#!/bin/bash

adb devices
sleep 1

for line in  $( cat packagelist.txt ) 
do  
    echo removing $line
    adb shell pm uninstall --user 0 $line 
done

Let me know if it works.

answered Feb 05 '20 at 12:02

Matias Barrios

4,674
3
22
49

[Don't read lines with `for`.](https://mywiki.wooledge.org/DontReadLinesWithFor) – tripleee Feb 05 '20 at 12:06
@tripleee None of the issues mentioned in your link apply to OPs use case. This will work correctly. – Matias Barrios Feb 05 '20 at 12:14
Are you sure? If you can explain what causes it, I'll be happy to reopen. I am unable to repro locally (Debian Buster running inside Docker). – tripleee Feb 05 '20 at 12:23
@tripleee Lets wait for OP then. I cant reproduce it either. But I have the feeling the *while* loop is the issue since something on the inner block is eating the stdin. – Matias Barrios Feb 05 '20 at 12:27
Well, that's precisely what the duplicate covers. – tripleee Feb 05 '20 at 12:28

Bash loop thru file takes only first line

1 Answers1