C# method from List to List

Question

I made a list of cars, the factory produces every 4 cars broken (public bool Broken;).

My code

public static void BuildCar()
{

    List<Factory> cars = new List<Factory>();

    for (int i = 1; i < 10; i++)
    {
        Factory newCars = new Cars("string", "string", "bool");
        if (i % 4 == 0)
        {
            newCars.Broken = true;
            cars.Add(newCars);
        }
        else
        {
            newCars.Broken = false;
            cars.Add(newCars);
        }
    }
}

What I did

A list of all the cars (good and broken).

What I need to do

Create a method that copies only good cars to another list.

Thx.

"sends me from the car list to another list"? Do you mean to add only unbroken cars to a separate list? If so, can't you add the unbroken cars to the second list directly in your existing code? — Lasse V. Karlsen, Feb 06 '20 at 13:24
Your question is not clear. Can you please provide how you want your output to look like ? — Aditya Bhave, Feb 06 '20 at 13:25
`List goodCars = newCars.Where(car => !car.Broken).ToList()`? — Steve, Feb 06 '20 at 13:26
public List GetGoodCars(List cars) {return cars.Where(car => !car.Broken).ToList()}; — JMP, Feb 06 '20 at 14:01

JMP · Accepted Answer · 2020-02-06T13:30:03.767

0

LINQ query:

var goodCars = cars.Where(car => !car.Broken).ToList();

edited Feb 06 '20 at 13:30

answered Feb 06 '20 at 13:27

JMP

1,864
2
8
16

Avoid ToList() operator , just use where opertor who returns a lazily evaluated sequence - no copying is required – KHL Feb 06 '20 at 13:47
@KhalilLazhar Why do you keep referring to methods as `operators`? – ThePerplexedOne Feb 06 '20 at 13:50
@ThePerplexedOne https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/linq/classification-of-standard-query-operators-by-manner-of-execution – KHL Feb 06 '20 at 13:55
@ThePerplexedOne Microsoft call them Standard Query Operators :)) – KHL Feb 06 '20 at 13:55
@ThePerplexedOne if you want to call them methods then call them extension methods :)) – KHL Feb 06 '20 at 13:56
1

Which is exactly what I do call them. – ThePerplexedOne Feb 06 '20 at 13:58
@ThePerplexedOne technically they are an extensions methods.. we call them specially operators in LINQ .... – KHL Feb 06 '20 at 14:06

score -1 · Answer 2 · answered Feb 06 '20 at 13:27

-1

The simplest way probably:

List<Factory> goodCars = cars.FindAll(car => !car.Broken);

answered Feb 06 '20 at 13:27

VillageTech

1,968
8
18

1

'Where' is faster than 'FindAll' , where opertor returns a lazily evaluated sequence - no copying is required like 'FindAll' – KHL Feb 06 '20 at 13:34

C# method from List to List

2 Answers2