Can't get out this while loop

Question

I want this loop to break when user enters anything but y or Y. But, instead the Enter the new location prompt is returning again and again.

    def add_locations(self):
        while True:
            new = str(input("Enter the new loation: "))
            self.locations.append(new)
            ask = str(input("add new location? (y/n):  "))
            if ask == 'y' or 'Y':
                continue
            else:
                break

BTW your `str()` conversion is not necessary as `input()` already returns a string — Tomerikoo, Feb 15 '20 at 11:37

score 3 · Accepted Answer · answered Feb 15 '20 at 11:18

3

Your if-clause is evaluated like this: (ask == 'y') or 'Y' and 'Y' is always true. You need to ask if ask == 'y' or ask == 'Y': instead

answered Feb 15 '20 at 11:18

peer

4,171
8
42
73

1

It's a good practice to use parentheses: `if (ask == 'y') or (ask == 'Y')` – trsvchn Feb 15 '20 at 11:25
2

Or a better practice to do `if ask in ('y', 'Y')` or in this particular case: `if ask.lower() == 'y'` – Tomerikoo Feb 15 '20 at 11:34
@Tomerikoo yes! you're definitely right! – trsvchn Feb 15 '20 at 11:44

trsvchn · Answer 2 · 2020-02-15T11:45:57.820

1

Alternatively, you can put all your positive values into a tuple:

while True:
    new = str(input("Enter the new location: "))
    self.locations.append(new)
    ask = str(input("add new location? (y/n):  "))
    if ask.lower() in ('y', 'yes'):
        continue
    else:
        break

edited Feb 15 '20 at 11:45

answered Feb 15 '20 at 11:29

trsvchn

8,033
3
23
30

Yes, that's a good alternative. Thanks. – forest Feb 15 '20 at 11:35

Can't get out this while loop

2 Answers2