Inserting indexed array into an database with PHP and MySqli

Question

I'm trying to get an indexed array's values inserted into a SQL database with MySQLi and PHP but I can't figure out why it's not working.

$con = mysqli_connect("localhost","user","pword","db");
if (mysqli_connect_errno()) {
   echo "Unable to connect to MySQL! ". mysqli_connect_error();
   exit();
}

$sqli = "INSERT INTO path_info (path_name,operating_frequency,pi_description,pi_note) VALUES (?,?,?,?)";
$stmt= $con->prepare($sqli);
$stmt->bindParam("ssss",$csv[0],$csv[1],$csv[2],$csv[3]);
$status = $stmt->execute();
if (!$status) {
    echo "Error ".$stmt->errorCode()."\nMessage ".implode($stmt->errorInfo())."\n";
    exit(1);
}

Show the value of $csv[0]. and what is value of $status after executing the code? — Ankur Mishra, Feb 16 '20 at 07:29
I removed the ; from the insert, $csv[0] should be a string value. How would I get the value of $status? — Zurich in Pain, Feb 16 '20 at 07:37
Please read: [Should we ever check for mysqli_connect() errors manually?](https://stackoverflow.com/q/58808332/1839439) — Dharman, Feb 16 '20 at 13:31

Ankur Mishra · Answer 1 · 2020-02-16T10:43:39.523

1

It's bind_param when working with mysqli. It's bindParam when working with PDO.

<?php
    $con = mysqli_connect("localhost","user","pword","db");
    if (mysqli_connect_errno()) {
       echo "Unable to connect to MySQL! ". mysqli_connect_error();
       exit();
    }

    $sqli = "INSERT INTO path_info (path_name,operating_frequency,pi_description,pi_note) VALUES (?,?,?,?)";
    $stmt= $con->prepare($sqli);
    $stmt->bind_param("ssss", $csv[0],$csv[1],$csv[2],$csv[3]);
    $status = $stmt->execute();

edited Feb 16 '20 at 10:43

answered Feb 16 '20 at 08:00

Ankur Mishra

1,284
1
6
15

check code connection string too – Ronak Dhoot Feb 16 '20 at 08:03
@RonakDhoot, sorry the connection is that which I used for my local system to test code. Sorry for that. – Ankur Mishra Feb 16 '20 at 08:06
it should be PDO connection not mysqli_connect – Ronak Dhoot Feb 16 '20 at 08:08
1

It is working fine on my local system. – Ankur Mishra Feb 16 '20 at 08:09
Please read: [Should we ever check for mysqli_connect() errors manually?](https://stackoverflow.com/q/58808332/1839439) – Dharman Feb 16 '20 at 13:31

Ronak Dhoot · Accepted Answer · 2020-02-16T14:07:35.340

-2

problem is at bindParam

$stmt->bindParam(1,$csv[0]);
$stmt->bindParam(2,$csv[1]);
$stmt->bindParam(3,$csv[2]);
$stmt->bindParam(4,$csv[3]);

correct format is as above

also use try-catch

$con= new PDO("mysql:host=127.0.0.1;dbname=task", 'root', 'root');
$con->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
$csv = array('test', 15, 'testing', 'noted');
$sqli = "INSERT INTO path_info (path_name,operating_frequency,pi_description,pi_note) VALUES (?,?,?,?)";

$stmt= $con->prepare($sqli);
$stmt->bindParam(1,$csv[0]);
$stmt->bindParam(2,$csv[1]);
$stmt->bindParam(3,$csv[2]);
$stmt->bindParam(4,$csv[3]);
$status = $stmt->execute(); 
if (!$stmt) {
    echo PDO::errorInfo();
}

edited Feb 16 '20 at 14:07

answered Feb 16 '20 at 07:39

Ronak Dhoot

2,322
1
12
19

Still returning empty set – Zurich in Pain Feb 16 '20 at 07:45
your connection type is also require to be updated as PDO connection – Ronak Dhoot Feb 16 '20 at 07:50
Ok, that's added, but it's still not in the db, should I add more of my code to the post? – Zurich in Pain Feb 16 '20 at 07:58
refer updated code it working smoothly at my local – Ronak Dhoot Feb 16 '20 at 08:03
hmm, must be an issue with my array then, thanks for your help. – Zurich in Pain Feb 16 '20 at 08:07
1

DO NOT use try catch. it is useless here – Your Common Sense Feb 16 '20 at 08:07
@YourCommonSense Should I just leave it how I had it before? as far as try catch goes? – Zurich in Pain Feb 16 '20 at 08:11
@ZurichinPain the first and foremost thing you have to do is to make your mind **which database API** you are going to use, PDO or mysqli. Your question is tagged with mysqli, your code is a mix between mysqli and PDO and you accepted the answer with PDO. – Your Common Sense Feb 16 '20 at 08:16
@ZurichinPain the way you had it before is even more useless. There should be no try catch nor if (!$status) {. PHP can report errors all by itself, no assistance required. – Your Common Sense Feb 16 '20 at 08:18
I'm going to use whichever one I can get to work. – Zurich in Pain Feb 16 '20 at 08:25
I can't upvote this answer, because of try-catch. Never catch exceptions if you don't know how to recover. – Dharman Feb 16 '20 at 13:34
@Dharman removed `try-catch` – Ronak Dhoot Feb 16 '20 at 13:56
But you added the `if` statement. That's not an improvement. The point is never display the error message! Don't check for errors manually and don't catch the exceptions. – Dharman Feb 16 '20 at 13:58
You use `$stmt` so obviously it is not false. This `if` will never be executed. Such error checking is completely useless, because any call to any of the methods could fail and the rest of the code would never be executed. – Dharman Feb 16 '20 at 14:04
I am printing PDO::errorInfo() not stoping code to be executed – Ronak Dhoot Feb 16 '20 at 14:07

Inserting indexed array into an database with PHP and MySqli

2 Answers2