App crashes when opening after building it with Xcode 11.3.1

Question

After upgrading to Xcode 11.3.1 we noticed that our app started to crash on some devices when opening. It happens on different iOS versions and iPhone models. However on some devices with the same iOS version or iPhone model the app works fine.

When installing an earlier build of the app on these devices (that was build with an earlier Xcode version) the crash does not occur.

While debugging we found out that the crash occurs when trying to unwrap an Optional when using the presenter of our login module. This presenter has a value when created and is assigned but after setting our rootViewController in the AppDelegate window.rootViewController = navigationController the execution jumps to the viewDidLoad() function shown below at which point the presenter is nil.

class LoginViewController: LoginPasswordResetViewController {
    var presenter: LoginPresenterProtocol!

    override func viewDidLoad() {
        super.viewDidLoad()

        updateUI(model: presenter.loadViewModel())
        presenter.viewDidLoad()
    }
}

Relevant code in AppDelegate.swift:

class AppDelegate: UIResponder, UIApplicationDelegate {
var window: UIWindow?

func application(_: UIApplication, didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {

    let env = Environment()

    if let app = UIApplication.shared.delegate as? AppDelegate,
        let window = app.window,
        let loginVC = LoginModule().createModule(moduleData: LoginModuleData(env: env),
                                                 service: LoginService(env: env),
                                                 storageService: LocalStorageService(env: env)) {

        let navigationController = UINavigationController(rootViewController: loginVC)

        window.rootViewController = navigationController
        window.makeKeyAndVisible()
    }
    return true
}

I tried using the SceneDelegate.swift mentioned here Set RootViewController iOS 13 to set the RootViewController with no luck.

Any ideas on what could be the cause of this issue?

Additional info:

The createModule function initializes and sets the presenter:

func createModule(moduleData: LoginModuleDataProtocol, service: LoginServiceProtocol, storageService: LocalStorageServiceProtocol) -> LoginViewController? {
    guard let viewController: LoginViewController = UIStoryboard.viewController(from: self) else {
        return nil
    }
    let presenter = LoginPresenter()
    let interactor = LoginInteractor()
    let router = LoginRouter()

    // VC
    viewController.presenter = presenter
    // Presenter
    presenter.viewController = viewController
    presenter.interactor = interactor
    presenter.router = router
    // Interactor
    interactor.presenter = presenter
    interactor.dataManager = LoginDataManager(data: moduleData, service: service, storageService: storageService)
    // Router
    router.viewController = viewController

    return viewController
}

After creating the module, the loginVC variable has the presenter value as it should but as soon as we assign window.rootViewController = navigationController the value of presenter is nil.

When it only crashes on _some_ devices, it might be a timing problem. How does the `createModule` function set the `presenter` property of the `loginVC`? — Andreas Oetjen, Feb 18 '20 at 15:19
I added some additional info @AndreasOetjen, the `loginVC` has a valid `presenter` after calling the `createModule` function. — rroscher, Feb 19 '20 at 09:18
does your viewcontroller has a strong reference to presenter? — Manoj, Feb 19 '20 at 09:22
@Manoj The first code bit is the `LoginViewController` class (forgot to add it), so the reference should be strong. — rroscher, Feb 19 '20 at 09:46

score 0 · Accepted Answer · answered Feb 25 '20 at 08:46

I managed to make it work. I had to use the SceneDelegate to load the components to launch my app for iOS 13 while still supporting iOS 12 but I only managed to make it work after reading how to configure it properly.

So here is the result that worked for me:

SceneDelegate.swift:

import UIKit
@available(iOS 13.0, *)
class SceneDelegate: UIResponder, UIWindowSceneDelegate {
    var window: UIWindow?

    func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {
        let env = Environment()

        if let windowScene = scene as? UIWindowScene,
            let loginVC = LoginModule().createModule(moduleData: LoginModuleData(env: env),
                                                     service: LoginService(env: env),
                                                     storageService: LocalStorageService(env: env)) {
            self.window = UIWindow(windowScene: windowScene)
            self.window!.rootViewController = UINavigationController(rootViewController: loginVC)
            self.window!.makeKeyAndVisible()
        }
    }
}

AppDelegate.swift:

import UIKit

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
    var window: UIWindow?

    func application(_: UIApplication, didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        if #available(iOS 13.0, *) {} else {
            let env = Environment()

            if let app = UIApplication.shared.delegate as? AppDelegate,
                let window = app.window,
                let loginVC = LoginModule().createModule(moduleData: LoginModuleData(env: env),
                                                         service: LoginService(env: env),
                                                         storageService: LocalStorageService(env: env)) {
                window.rootViewController = UINavigationController(rootViewController: loginVC)
                window.makeKeyAndVisible()
            }
        }
        return true
    }

App crashes when opening after building it with Xcode 11.3.1

1 Answers1