Optimize group of characters for a cleaner code

Question

I need some help whit the optimization of this group of characters [qwertyuiopasdfghjklzxcvbnmàèìòùÀÈÌÒÙáéíóúýÁÉÍÓÚÝâêîôûÂÊÎÔÛãñõÃÑÕäëïöüÿÄËÏÖÜŸçÇßØøÅåÆæœ] obviously it is really big so I need it smaller so I can use it into a regex, like this:

let N = /^N1\d{14}[^qwertyuiopasdfghjklzxcvbnmàèìòùÀÈÌÒÙáéíóúýÁÉÍÓÚÝâêîôûÂÊÎÔÛãñõÃÑÕäëïöüÿÄËÏÖÜŸçÇßØøÅåÆæœ]{78}$/;

I tried examples from other sites and this one too but didn't work as expected, can some one help me?

This regex is supposed to match a type of register like this one:

Register

N108258594000135255240708     315370        BLABLA BLABLABL BLAB BLA

What does the expression's length have to do with it working or not? — Sean Bright, Feb 18 '20 at 19:02
Describe in plain language what the regex is supposed to match. — Gary_W, Feb 18 '20 at 19:06
Have a look: https://stackoverflow.com/questions/22017723/regex-for-umlaut — PM 77-1, Feb 18 '20 at 19:08
Please indicate which language or tool you're using. There are many different flavors of regex, some of which have built-in character sets for this sort of thing. — CAustin, Feb 18 '20 at 19:10
For starters `a-z` could be used to replace `qwertyuiopasdfghjklzxcvbnm` — MonkeyZeus, Feb 18 '20 at 19:13

score 0 · Answer 1 · answered Feb 18 '20 at 19:39

0

Why are you negating the character group ? Isn't it better to enumerate the characters that can appear instead of those that mustn't ?

This would be a much cleaner regex:

let N = /^N1\d{14}[ 0-9A-Z]{78}$/;

answered Feb 18 '20 at 19:39

Lorenz Meyer

19,166
22
75
121

Because those 78 must be all in uppercase and without any type of accentuation or lowercase, but especifically ```can't``` match ```those``` characters – Lagaggio Feb 18 '20 at 19:42
@Lagaggio Yes, just because they must be all uppercase without accentuation or lowercase, my solution is better. It does allow only uppercase letters, numbers and spaces. It is impossible to enumerate all accentuated letters. Look into Unicode... – Lorenz Meyer Feb 18 '20 at 19:59
But is it going to allow me to introduce a ```?```, ```|``` or a ```!``` ? – Lagaggio Feb 18 '20 at 20:11

Optimize group of characters for a cleaner code

1 Answers1