This script always says that i made an invalid choice. If statement might be ignored

Question

I have been trying to make this calculator work but it always says that my choice is invalid. I tried valid numbers and for some reason it doesn't work. Any help would be appreciated. I'm still new to python and to programming in general. Thanks.

#Calculator
print("1.Addition")
print("2.Substraction")
print("3.Multiplication")
print("4.Divison")
#Choose the calculation
Choice=int(input("Enter your choice (1/2/3/4): "))
#Inserting the numbers
Num1=float(input("Insert your first number: "))
Num2=float(input("Insert your second number: "))

if Choice == '1':
    ans= Num1 + Num2
    print("Your answer is: ",ans)

elif Choice == '2':
    ans= Num1 - Num2
    print("Your answer is: ",ans)

elif Choice == '3':
    ans= Num1*Num2
    print("Your answer is: ",ans)

elif Choice == '4':
    ans= Num1/Num2
    print("Your answer is: ",ans)

else:
    print("Invalid choice. ")

also remember that its a proper python convention to use camelCase when declaring variables — Ironkey, Feb 25 '20 at 15:37
@ironkey _also remember that its a proper python convention to use camelCase when declaring variables_ Don't you mean the opposite? — AMC, Feb 25 '20 at 15:48
Does this answer your question? [How can I read inputs as numbers?](https://stackoverflow.com/questions/20449427/how-can-i-read-inputs-as-numbers) — AMC, Feb 25 '20 at 15:49
I wasnt saying his issue was not using camelCase just pointing him to use it — Ironkey, Feb 25 '20 at 15:51

score 2 · Answer 1 · answered Feb 25 '20 at 15:35

2

Modify the if conditions, replacing the strings with the numbers themselves:

if Choice == 1:
    ans= Num1 + Num2
    print("Your answer is: ",ans)

elif Choice == 2:
    ans= Num1 - Num2
    print("Your answer is: ",ans)

elif Choice == 3:
    ans= Num1*Num2
    print("Your answer is: ",ans)

elif Choice == 4:
    ans= Num1/Num2
    print("Your answer is: ",ans)

else:
    print(f"Invalid choice.")

answered Feb 25 '20 at 15:35

leqo

356
4
15

Thanks for helping me! – IskandarG Feb 25 '20 at 15:37

score 1 · Accepted Answer · answered Feb 25 '20 at 15:36

the problem is your checking if the answer is equivalent to a STRING not an integer!

#Calculator
print("1.Addition")
print("2.Substraction")
print("3.Multiplication")
print("4.Divison")
#Choose the calculation
choice=int(input("Enter your choice (1/2/3/4): "))
#Inserting the numbers1
Num1=int(input("Insert your first number: "))
Num2=int(input("Insert your second number: "))

if choice == 1:
    ans= Num1 + Num2
    print("Your answer is: ",ans)
elif choice == 2:
    ans= Num1 - Num2
    print("Your answer is: ",ans)
elif choice == 3:
    ans= Num1*Num2
    print("Your answer is: ",ans)
elif choice == 4:
    ans= Num1/Num2
    print("Your answer is: ",ans)
else:
    print("Invalid choice. ")

score 0 · Answer 3 · answered Feb 25 '20 at 15:36

0

Choice=int(input("Enter your choice (1/2/3/4): "))

Choice is an int.

if Choice == '1':

You are comparing it against a String('1'). So your if-statements will not work.

Try this:

if Choice == 1:

answered Feb 25 '20 at 15:36

rdas

20,604
6
33
46

This script always says that i made an invalid choice. If statement might be ignored

3 Answers3