How to put values from DataReader into List?

Question

Possible Duplicate:
How can I easily convert DataReader to List<T>?

I want to put the data which is coming from datareader object in a generic list. I have done like this but it doesn't work...

I am getting cast exception error in foreach row!

 SqlDataReader pointreader = cmd2.ExecuteReader();
 var pointt = new List<int>();
 while (pointreader.Read())
 {
     foreach (int item in pointreader)
     {
        pointt.Add(item);
         if (pointt.Contains(point))
         {
             matchpoint = item;
         }
     }
 }

Possible get from here [link](http://stackoverflow.com/questions/1464883/how-can-i-easily-convert-datareader-to-listt) — Developer, May 18 '11 at 09:26
Please rename your variables' name into something English-written — abatishchev, May 18 '11 at 09:40

score 8 · Accepted Answer · answered May 18 '11 at 09:35

SqlDataReader cannot be accessed in the way you have described as it does not implement IEnumerable. Instead you need to access each field individually:

SqlDataReader puanoku = cmd2.ExecuteReader();
List<int> puann = new List<int>();
while (puanoku.Read())
{
    for (int i = 0; i < puanoku.FieldCount; i++)
    {
        if (puanoku.GetFieldType(i) == typeof(int))
        {
            // Do something here
        }
    }
}

If you've only selected one column and are certain that it is an int then you can simplify the code like so:

SqlDataReader puanoku = cmd2.ExecuteReader();
List<int> puann = new List<int>();
while (puanoku.Read())
{
    int value = puanoku.GetInt32(1);

    // Do something with the int here...
}

This article may be of some use.

I have one column but Column has more than one value.. I want to check eslesenpuan contains puan generic list if(puan.contains(eslesenpuan)) I want to update that point.. — PsyGnosis, May 18 '11 at 10:01

score 3 · Answer 2 · edited Aug 24 '12 at 11:00

3

I think you need to get item from the Reader, like puanoku["item"] and convert it to int. Add then only you can add it to the list.

while(Reader.Read())
{
  var myId = (int)Reader["myId"];
  myIdList.Add(myId); // or you can do myIdList.Add(int)Reader["myId"]);
}

edited Aug 24 '12 at 11:00

Diego

34,802
21
91
134

answered May 18 '11 at 09:24

Anuraj

18,859
7
53
79

score 0 · Answer 3 · answered May 18 '11 at 09:25

The datareader is a pointer to rows in a table. You can get to the individual attributes using an indexer on the reader and use the FieldCount property to obtain the values.

 while (puanoku.Read())
 {
  for(int i = 0; i < puanoku.FieldCount)
  {
      puann.Add(puanoku.GetInt32(i));
  }
 }

If you only want unique values you should use a HashSet rather than a List since it will test for existence in O(1) rather than O(n).

How to put values from DataReader into List?

3 Answers3

Linked