OClint warning confusion for C

Asked Mar 03 '20 at 19:18

Active Mar 03 '20 at 19:20

Viewed 60 times

I have a program with the following line of code in it

if (counter % 2 == 1){

and OClint is giving me the warning "broken oddness check", which from the documentation states that it won't work for negative numbers, which I understand, but the solutions it gave me was to use

if (counter % 2 != 0){

which then gives me an "inverted logic warning" and tells me to use the first code again... I'm not sure what I'm supposed to do here. Thanks!

edited Mar 03 '20 at 19:20

walnut

21,629
4
23
59

asked Mar 03 '20 at 19:18

William

5

How about `if (counter % 2)` ? – Eugene Sh. Mar 03 '20 at 19:20
Solved! I can't believe I didn't think of that. Thank you! – William Mar 03 '20 at 19:22
3

That second warning is kind of dumb in this case. Yes, inverting logic is often less than desirable, but it's still better than the non-explicit option of neglecting to mention what exactly you're testing equality against. – Carcigenicate Mar 03 '20 at 19:23
1

@Carcigenicate I agree. I think some might consider it more readable than the "accepted" solution. – Eugene Sh. Mar 03 '20 at 19:25
1

Another option would be to use an unsigned integer type for `counter` — how often do you need a negative count? – Jonathan Leffler Mar 03 '20 at 21:14
@jonathan: That depends on what you're counting. If it is mistakes, then you do need a negative count :) – machine_1 Mar 03 '20 at 22:11

OClint warning confusion for C

0 Answers0