Help needed for 'cross-thread operation error' in C#

Question

In the following code MessageReceived is on a different thread to label1 and when trying to access it I will get this error:

Cross-thread operation not valid: Control 'label1' accessed from a thread other than the thread it was created on.

foo.MessageReceived += new Agent.MessageReceivedHandler(foo_MessageReceived); 

void foo_MessageReceived(Message message)
{
   label1.Text = message.Body;
}

How can I solve this?

More: apparently I need to use delegate and invoke, but I don't know how, can you please explain in more detail?

Exact duplicate (not NPR, as I mistakenly clicked): http://stackoverflow.com/questions/244591 http://stackoverflow.com/questions/142003 http://stackoverflow.com/questions/470390 amongst others. — Jon Skeet, Mar 03 '09 at 14:52

score 4 · Answer 1 · answered Mar 03 '09 at 14:53

Hopefully this will be closed as an exact duplicate, but if not:

Don't touch the GUI from a non-GUI thread. Use BackgroundWorker and report progress appropriately, or read the WinForms page of my threading article for more direct control (Control.Invoke/BeginInvoke).

score 1 · Answer 2 · answered Mar 03 '09 at 14:46

1

Delegate updating the label to the thread that created the label instead of trying to update it directly.

answered Mar 03 '09 at 14:46

Welbog

59,154
9
110
123

score 1 · Answer 3 · answered Mar 03 '09 at 15:10

You need to use Control.Invoke (or Control.BeginInvoke). First, create a new Windows Forms application and add a label and a button. Double click on the button in Visual Studio to edit it's Click event and add the following code:

    private void button1_Click(object sender, EventArgs e)
    {
        new System.Threading.Thread(new System.Threading.ThreadStart(Run)).Start();
    }

    void Run()
    {
        label1.Invoke(new Action(delegate()
        {
            label1.Text = System.Threading.Thread.CurrentThread.Name + " " + System.DateTime.Now.ToString();
        }));
    }

The key piece that is needed from this answer is the Invoke call. — ConsultUtah, Mar 03 '09 at 15:13

Restore the Data Dumps · Answer 4 · 2009-03-03T14:56:12.743

0

This is totally not helpful. I wish I could vote myself down.

I may be out of date, but from what I remember you aren't allowed to alter anything in the GUI from anything but the main thread.

edited Mar 03 '09 at 14:56

answered Mar 03 '09 at 14:45

Restore the Data Dumps

38,967
12
96
122

score 0 · Answer 5 · answered Mar 03 '09 at 14:57

In your Agent class, when you raise the MessageReceived event, you'll have to check whether the Target of the event-handler implements ISynchronizeInvoke. If it does, and if the InvokeRequired property returns true, you'll have to invoke the eventhandler.

If you're not using WinForms, but WPF, you cannot rely anymore on ISynchronizeInvoke since the WPF controls do not implement that interface. Instead, you'll have to work with AsyncOperation and AsyncOperatoinManager.

score 0 · Accepted Answer · edited Apr 13 '12 at 13:20

Make always sure you update your GUI on the main thread (GUI thread).

foo.MessageReceived += new Agent.MessageReceivedHandler(foo_MessageReceived);

public delegate void MyDelegate(Message msg);
void foo_MessageReceived(Message message)
{ 
   if (InvokeRequired)
   {
      BeginInvoke(new MyDelegate(foo_MessageReceived),new object[]{message});
   }
   else
   {
      label1.Text = message.Body;
   }
}

Help needed for 'cross-thread operation error' in C#

6 Answers6

Linked

Related